From 8751b45982c1213342d419b92fedab8eae2779e1 Mon Sep 17 00:00:00 2001 From: "Matthias J. Kannwischer" Date: Wed, 14 Jan 2026 10:18:08 +0800 Subject: [PATCH] Examples: Remove MLD_CONFIG_NO_SUPERCOP from multi-level header MLD_CONFIG_NO_SUPERCOP is already set in the configuration file; it should not be set again in mldsa_native_all.h. - Ports https://github.com/pq-code-package/mlkem-native/pull/1477 Signed-off-by: Matthias J. Kannwischer --- examples/monolithic_build_multilevel/README.md | 3 +-- examples/monolithic_build_multilevel/mldsa_native_all.h | 2 -- examples/monolithic_build_multilevel_native/README.md | 1 + examples/multilevel_build/README.md | 1 + examples/multilevel_build_native/README.md | 1 + 5 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/monolithic_build_multilevel/README.md b/examples/monolithic_build_multilevel/README.md index e25bc0127..c83238fc4 100644 --- a/examples/monolithic_build_multilevel/README.md +++ b/examples/monolithic_build_multilevel/README.md @@ -32,6 +32,7 @@ The configuration file [mldsa_native_config.h](mldsa_native/mldsa_native_config. - `MLD_CONFIG_MULTILEVEL_BUILD`: Enables multi-level mode - `MLD_CONFIG_NAMESPACE_PREFIX=mldsa`: Base prefix - `MLD_CONFIG_INTERNAL_API_QUALIFIER=static`: Makes internal functions static +- `MLD_CONFIG_NO_SUPERCOP`: Disables the SUPERCOP API (crypto_sign*) The wrapper [mldsa_native_all.c](mldsa_native_all.c) includes `mldsa_native.c` three times: ```c @@ -59,8 +60,6 @@ The wrapper [mldsa_native_all.c](mldsa_native_all.c) includes `mldsa_native.c` t The header [mldsa_native_all.h](mldsa_native_all.h) exposes all APIs: ```c -#define MLD_CONFIG_NO_SUPERCOP - #define MLD_CONFIG_PARAMETER_SET 44 #include #undef MLD_CONFIG_PARAMETER_SET diff --git a/examples/monolithic_build_multilevel/mldsa_native_all.h b/examples/monolithic_build_multilevel/mldsa_native_all.h index d58748361..3cfd58dee 100644 --- a/examples/monolithic_build_multilevel/mldsa_native_all.h +++ b/examples/monolithic_build_multilevel/mldsa_native_all.h @@ -7,8 +7,6 @@ #ifndef MLD_ALL_H #define MLD_ALL_H -#define MLD_CONFIG_NO_SUPERCOP - /* API for MLDSA-44 */ #define MLD_CONFIG_PARAMETER_SET 44 #include diff --git a/examples/monolithic_build_multilevel_native/README.md b/examples/monolithic_build_multilevel_native/README.md index 92b0198f5..2d4305a86 100644 --- a/examples/monolithic_build_multilevel_native/README.md +++ b/examples/monolithic_build_multilevel_native/README.md @@ -31,6 +31,7 @@ The configuration file [mldsa_native_config.h](mldsa_native/mldsa_native_config. - `MLD_CONFIG_NAMESPACE_PREFIX=mldsa`: Base prefix - `MLD_CONFIG_USE_NATIVE_BACKEND_ARITH`: Enables native arithmetic backend - `MLD_CONFIG_USE_NATIVE_BACKEND_FIPS202`: Enables native FIPS-202 backend +- `MLD_CONFIG_NO_SUPERCOP`: Disables the SUPERCOP API (crypto_sign*) The wrapper [mldsa_native_all.c](mldsa_native_all.c) includes `mldsa_native.c` three times: ```c diff --git a/examples/multilevel_build/README.md b/examples/multilevel_build/README.md index 9fd066c76..577f1a863 100644 --- a/examples/multilevel_build/README.md +++ b/examples/multilevel_build/README.md @@ -26,6 +26,7 @@ The library is built 3 times into separate directories (`build/mldsa44`, `build/ The configuration file [mldsa_native_config.h](mldsa_native/mldsa_native_config.h) sets: - `MLD_CONFIG_MULTILEVEL_BUILD`: Enables multi-level build mode - `MLD_CONFIG_NAMESPACE_PREFIX=mldsa`: Base prefix; level suffix added automatically +- `MLD_CONFIG_NO_SUPERCOP`: Disables the SUPERCOP API (crypto_sign*) Build-time flags passed via CFLAGS: - `MLD_CONFIG_PARAMETER_SET=44/65/87`: Selects the security level diff --git a/examples/multilevel_build_native/README.md b/examples/multilevel_build_native/README.md index 8265fe528..d253ec827 100644 --- a/examples/multilevel_build_native/README.md +++ b/examples/multilevel_build_native/README.md @@ -30,6 +30,7 @@ The configuration file [mldsa_native_config.h](mldsa_native/mldsa_native_config. - `MLD_CONFIG_NAMESPACE_PREFIX=mldsa`: Base prefix; level suffix added automatically - `MLD_CONFIG_USE_NATIVE_BACKEND_ARITH`: Enables native arithmetic backend - `MLD_CONFIG_USE_NATIVE_BACKEND_FIPS202`: Enables native FIPS-202 backend +- `MLD_CONFIG_NO_SUPERCOP`: Disables the SUPERCOP API (crypto_sign*) Build-time flags passed via CFLAGS: - `MLD_CONFIG_PARAMETER_SET=44/65/87`: Selects the security level