Commit 2b60254
committed
CBMC: Add x86-64 HOL-Light-based contracts and proofs
- This commit introduces CBMC verification for several x86-64 optimized
assembly functions. The contracts for these functions are derived from
their corresponding HOL-Light correctness proofs.
- For each assembly function, a CBMC contract has been added to
`arith_native_x86_64.h`. Additionally, new proof harnesses have been
creat to formally verify that the generic C implementations (`*_native`)
correctly utilize these assembly backends and adhere to the top-level
API contracts.
- The following functions now have CBMC proofs based on their
HOL-Light specifications:
- polyvec_basemul_acc_montgomery_cached_asm_k2/k3/k4:
- Pre-conditions:
`<= &2 pow 12`(HOL_LIGHT) v.s. `MLKEM_UINT12_LIMIT + 1`(CBMC)
- Adds a CBMC pre-condition:
`requires(array_abs_bound(a, 0, 4 * MLKEM_N, MLKEM_UINT12_LIMIT +`
`1))`
- ntt_avx2:
- Pre-condition:
`<= &8191`(HOL_LIGHT) v.s. `8191 + 1`(CBMC)
- Post-condition:
`<= &23594`(HOL_LIGHT) v.s. `23594 + 1`(CBMC)
- Adds a CBMC pre-condition:
`requires(array_abs_bound(r, 0, MLKEM_N, 8192))`
- Adds a CBMC post-condition:
`ensures(array_abs_bound(r, 0, MLKEM_N, 23595))`
- intt_avx2:
- Post-condition:
`<= &26631` v.s. `26631 + 1`(CBMC)
- Adds a CBMC post-condition:
`ensures(array_abs_bound(r, 0, MLKEM_N, 26632))`
- reduce_avx2:
- Post-condition:
`< &3329`(HOL_LIGHT) v.s. `3329 == MLKEM_Q`(CBMC)
- Adds a CBMC post-condition:
`ensures(array_bound(r, 0, MLKEM_N, 0, MLKEM_Q))`
- tobytes_avx2:
- Pre-condition:
`num_of_wordlist (MAP word_zx l:(12 word)list))`(HOL_LIGHT)
v.s.
`MLKEM_UINT12_LIMIT`(CBMC)
- Adds a CBMC pre-condition:
`requires(array_bound(a, 0, MLKEM_N, 0, MLKEM_UINT12_LIMIT))`
- frombytes_avx2:
- Post-conditions:
`read (memory :> bytes(a,dimindex(:32) * 12)) s0 =
num_of_wordlist (l:(12 word)list)`
- Adds a CBMC post-condition:
`ensures(array_bound(r, 0, MLKEM_N, 0, MLKEM_UINT12_LIMIT))`
- mlk_rej_uniform_asm:
- This proof are reference from aarch64 one, and change requires:
`requires(buflen % 24 == 0)` to `requires(buflen % 12 == 0)`
- mlk_tomont_avx2:
- Post conditions:
`(ival z_i == (tomont_3329 (ival o x)) i) (mod &3329) /\
abs(ival z_i) <= &3328)`
v.s.
`ensures(array_abs_bound(r, 0, MLKEM_N, MLKEM_Q))`
- Add a CBMC post-condition:
`ensures(array_abs_bound(r, 0, MLKEM_N, 3328 + 1))`
Signed-off-by: willieyz <[email protected]>1 parent 3924baf commit 2b60254
File tree
23 files changed
+958
-29
lines changed- dev/x86_64/src
- mlkem/src/native/x86_64/src
- proofs/cbmc
- intt_native_x86_64
- ntt_native_x86_64
- poly_frombytes_native_x86_64
- poly_reduce_native_x86_64
- poly_tobytes_native_x86_64
- poly_tomont_native_x86_64
- polyvec_basemul_acc_montgomery_cached_k2_native_x86_64
- polyvec_basemul_acc_montgomery_cached_k3_native_x86_64
- polyvec_basemul_acc_montgomery_cached_k4_native_x86_64
- rej_uniform_native_x86_64
- scripts
23 files changed
+958
-29
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | 16 | | |
22 | 17 | | |
23 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
24 | 34 | | |
25 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
26 | 47 | | |
27 | 48 | | |
28 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
29 | 60 | | |
30 | 61 | | |
31 | 62 | | |
32 | 63 | | |
33 | 64 | | |
34 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
35 | 73 | | |
36 | 74 | | |
37 | 75 | | |
| |||
42 | 80 | | |
43 | 81 | | |
44 | 82 | | |
45 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
46 | 95 | | |
47 | 96 | | |
48 | 97 | | |
49 | 98 | | |
50 | 99 | | |
51 | 100 | | |
52 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
53 | 113 | | |
54 | 114 | | |
55 | 115 | | |
56 | 116 | | |
57 | 117 | | |
58 | 118 | | |
59 | | - | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
60 | 131 | | |
61 | 132 | | |
62 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
63 | 140 | | |
64 | 141 | | |
65 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
66 | 149 | | |
67 | 150 | | |
68 | | - | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
69 | 158 | | |
70 | 159 | | |
71 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | 16 | | |
22 | 17 | | |
23 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
24 | 34 | | |
25 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
26 | 47 | | |
27 | 48 | | |
28 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
29 | 60 | | |
30 | 61 | | |
31 | 62 | | |
32 | 63 | | |
33 | 64 | | |
34 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
35 | 73 | | |
36 | 74 | | |
37 | 75 | | |
| |||
42 | 80 | | |
43 | 81 | | |
44 | 82 | | |
45 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
46 | 95 | | |
47 | 96 | | |
48 | 97 | | |
49 | 98 | | |
50 | 99 | | |
51 | 100 | | |
52 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
53 | 113 | | |
54 | 114 | | |
55 | 115 | | |
56 | 116 | | |
57 | 117 | | |
58 | 118 | | |
59 | | - | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
60 | 131 | | |
61 | 132 | | |
62 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
63 | 140 | | |
64 | 141 | | |
65 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
66 | 149 | | |
67 | 150 | | |
68 | | - | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
69 | 158 | | |
70 | 159 | | |
71 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
0 commit comments