Skip to content

Commit 3cc281e

Browse files
committed
enable the x86 hol interactive workflow
Signed-off-by: Dusan Kostic <[email protected]>
1 parent 71f93e0 commit 3cc281e

File tree

1 file changed

+20
-21
lines changed

1 file changed

+20
-21
lines changed

.github/workflows/hol_light.yml

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
# but we use this as a fast path to not even start the proofs
4444
# if the byte code needs updating.
4545
hol_light_bytecode:
46-
name: HOL-Light bytecode check
46+
name: AArch64 HOL-Light bytecode check
4747
runs-on: pqcp-arm64
4848
if: github.repository_owner == 'pq-code-package' && !github.event.pull_request.head.repo.fork
4949
steps:
@@ -57,7 +57,7 @@ jobs:
5757
script: |
5858
autogen --update-hol-light-bytecode --dry-run
5959
hol_light_interactive:
60-
name: HOL-Light interactive shell test
60+
name: AArch64 HOL-Light interactive shell test
6161
runs-on: pqcp-arm64
6262
needs: [ hol_light_bytecode ]
6363
if: github.repository_owner == 'pq-code-package' && !github.event.pull_request.head.repo.fork
@@ -71,7 +71,7 @@ jobs:
7171
nix-shell: 'hol_light'
7272
script: |
7373
make -C proofs/hol_light/arm mlkem/mlkem_poly_tobytes.o
74-
echo 'needs "proofs/mlkem_poly_tobytes.ml";;' | hol.sh
74+
echo 'needs "arm/proofs/mlkem_poly_tobytes.ml";;' | hol.sh
7575
hol_light_proofs:
7676
needs: [ hol_light_bytecode ]
7777
strategy:
@@ -151,7 +151,7 @@ jobs:
151151
152152
# x86_64 proofs
153153
hol_light_bytecode_x86_64:
154-
name: HOL-Light bytecode check
154+
name: x86_64 HOL-Light bytecode check
155155
runs-on: pqcp-x64
156156
if: github.repository_owner == 'pq-code-package' && !github.event.pull_request.head.repo.fork
157157
steps:
@@ -164,23 +164,22 @@ jobs:
164164
nix-shell: 'hol_light'
165165
script: |
166166
autogen --update-hol-light-bytecode --dry-run
167-
# TODO: fix the interactive mode to work for both x86 and arm.
168-
# hol_light_interactive_x86_64:
169-
# name: HOL-Light interactive shell test
170-
# runs-on: pqcp-x64
171-
# needs: [ hol_light_bytecode_x86_64 ]
172-
# if: github.repository_owner == 'pq-code-package' && !github.event.pull_request.head.repo.fork
173-
# steps:
174-
# - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
175-
# with:
176-
# fetch-depth: 0
177-
# - uses: ./.github/actions/setup-shell
178-
# with:
179-
# gh_token: ${{ secrets.GITHUB_TOKEN }}
180-
# nix-shell: 'hol_light'
181-
# script: |
182-
# make -C proofs/hol_light/x86 mlkem/mlkem_poly_basemul_acc_montgomery_cached_k2.o
183-
# echo 'needs "proofs/mlkem_poly_basemul_acc_montgomery_cached_k2.ml";;' | hol.sh
167+
hol_light_interactive_x86_64:
168+
name: x86_64 HOL-Light interactive shell test
169+
runs-on: pqcp-x64
170+
needs: [ hol_light_bytecode_x86_64 ]
171+
if: github.repository_owner == 'pq-code-package' && !github.event.pull_request.head.repo.fork
172+
steps:
173+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
174+
with:
175+
fetch-depth: 0
176+
- uses: ./.github/actions/setup-shell
177+
with:
178+
gh_token: ${{ secrets.GITHUB_TOKEN }}
179+
nix-shell: 'hol_light'
180+
script: |
181+
make -C proofs/hol_light/x86 mlkem/mlkem_poly_basemul_acc_montgomery_cached_k2.o
182+
echo 'needs "x86/proofs/mlkem_poly_basemul_acc_montgomery_cached_k2.ml";;' | hol.sh
184183
hol_light_proofs_x86_64:
185184
needs: [ hol_light_bytecode_x86_64 ]
186185
strategy:

0 commit comments

Comments
 (0)