Debug test: using stack-spill for mlkem-native fips202 slothy testing

- This commit change the SLOTHY version in nix/slothy/default.nix to
  stack-spill:
  slothy-optimizer/slothy@main...stack-spill
  This branch in slothy fix the issue: #230, make naming of
  stack location become configuratable.
- In this commit we set the name of stack location as MLK_STACK_LOC by
  --stack-loc-prefix=MLK_STACK_LOC

Signed-off-by: willieyz <[email protected]>

Author: willieyz

dev/fips202/aarch64/src/Makefile

@@ -10,6 +10,7 @@ keccak_f1600_x1_scalar_asm.S: ../../aarch64_symbolic/keccak_f1600_x1_scalar_symb
 
 	slothy-cli Arm_AArch64 Arm_Cortex_A55 \
 	   $^ -o $@ \
+           -c constraints.spill_stack_loc_prefix=MLK_STACK_LOC \
            -c reserved_regs="[x18,sp]" \
 	   -c inputs_are_outputs \
 	   -c variable_size \
@@ -23,6 +24,7 @@ keccak_f1600_x1_scalar_asm.S: ../../aarch64_symbolic/keccak_f1600_x1_scalar_symb
 
 	slothy-cli Arm_AArch64 Arm_Cortex_A55 \
 	   $@ -o $@ \
+           -c constraints.spill_stack_loc_prefix=MLK_STACK_LOC \
            -c reserved_regs="[x18,sp]" \
 	   -c variable_size \
 	   -c inputs_are_outputs \
@@ -38,6 +40,7 @@ keccak_f1600_x1_scalar_asm.S: ../../aarch64_symbolic/keccak_f1600_x1_scalar_symb
 keccak_f1600_x4_v8a_scalar_hybrid_asm.S: ../../aarch64_symbolic/keccak_f1600_x4_v8a_scalar_hybrid_clean.S
 	slothy-cli Arm_AArch64 Arm_Cortex_A55 \
 	   $^ -o $@                           \
+           -c constraints.spill_stack_loc_prefix=MLK_STACK_LOC \
 	   -c reserved_regs="[x18,sp]"        \
 	   -c inputs_are_outputs \
 	   -c variable_size \
@@ -54,6 +57,7 @@ keccak_f1600_x4_v8a_scalar_hybrid_asm.S: ../../aarch64_symbolic/keccak_f1600_x4_
 
 	slothy-cli Arm_AArch64 Arm_Cortex_A55 \
 	   $@ -o $@                           \
+           -c constraints.spill_stack_loc_prefix=MLK_STACK_LOC \
 	   -c reserved_regs="[x18,sp]"        \
 	   -c inputs_are_outputs \
 	   -c variable_size \
@@ -71,6 +75,7 @@ keccak_f1600_x4_v8a_scalar_hybrid_asm.S: ../../aarch64_symbolic/keccak_f1600_x4_
 keccak_f1600_x4_v8a_v84a_scalar_hybrid_asm.S: ../../aarch64_symbolic/keccak_f1600_x4_v8a_v84a_scalar_hybrid_clean.S
 	slothy-cli Arm_AArch64 Arm_Cortex_A55 \
 	   $^ -o $@                           \
+           -c constraints.spill_stack_loc_prefix=MLK_STACK_LOC \
 	   -c reserved_regs="[x18,sp]"        \
 	   -c inputs_are_outputs \
 	   -c variable_size \
@@ -87,6 +92,7 @@ keccak_f1600_x4_v8a_v84a_scalar_hybrid_asm.S: ../../aarch64_symbolic/keccak_f160
 
 	slothy-cli Arm_AArch64 Arm_Cortex_A55 \
 	   $@ -o $@                           \
+           -c constraints.spill_stack_loc_prefix=MLK_STACK_LOC \
 	   -c reserved_regs="[x18,sp]"        \
 	   -c inputs_are_outputs \
 	   -c variable_size \

nix/slothy/default.nix

@@ -17,12 +17,12 @@ let
 in
 stdenvNoCC.mkDerivation rec {
   pname = "slothy-cli";
-  version = "915c224166207ce07b31152194305c3b6687d09b";
+  version = "stack-spill";
   src = fetchFromGitHub {
     owner = "slothy-optimizer";
     repo = "slothy";
-    rev = version;
-    sha256 = "sha256-ebZjm+nhmML/+DZF78eN1ezoxbv5Rrc5kWsh0Ycww4U=";
+    rev = "stack-spill";
+    sha256 = "sha256-Vq/hbMsTTuwm1ms0yn8DIu2KAqcfKlUOhhwxqrr5Cls=";
   };
 
   nativeBuildInputs = [ pkgs.makeWrapper ];

scripts/autogen

@@ -2031,7 +2031,11 @@ def check_macro_typos():
 
         # 1. Makefiles use MLK_SOURCE_XXX to list source files
         if is_autogen or filename.endswith("/Makefile"):
-            if m.startswith("MLK_SOURCE") or m.startswith("MLK_OBJ"):
+            if (
+                m.startswith("MLK_SOURCE")
+                or m.startswith("MLK_OBJ")
+                or "STACK_LOC" in m
+            ):
                 return True
 
         # 2. libOQS specific identifier