Skip to content

Commit 2e620d9

Browse files
Fix some warnings in RunFlutterAction.java (flutter#7914)
@jwren fixing some warnings I am seeing as I'm opening files in the project. I'm on JVM 23 so I'm not sure if that is why I'm seeing these warnings, but please let me know if these are appropriate fixes. I just applied the suggestions from the warning in the IDE.
1 parent b7bcf5e commit 2e620d9

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

flutter-idea/src/io/flutter/FlutterBundle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ app.restart.action.description=Restart the Flutter app
1111
app.restart.all.action.text=Flutter Hot Restart (All Devices)
1212
app.restart.all.action.description=Restart all running Flutter apps on all connected devices
1313

14-
app.profile.action.text=Run in Flutter profile mode
14+
app.profile.action.text=Run in Flutter Profile Mode
1515
app.profile.config.action.text=Flutter Run ''{0}'' in Profile Mode
1616
app.profile.action.description=Run Flutter app in profile mode
1717

flutter-idea/src/io/flutter/actions/RestartFlutterAppRetarget.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import com.intellij.openapi.actionSystem.ActionPlaces;
99

1010
/**
11-
* A keystroke or tool-bar invoked {@link RestartFlutterApp} action.
11+
* A keystroke or toolbar invoked {@link RestartFlutterApp} action.
1212
*/
1313
public class RestartFlutterAppRetarget extends FlutterRetargetAppAction {
1414
public RestartFlutterAppRetarget() {

flutter-idea/src/io/flutter/actions/RunFlutterAction.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import javax.swing.*;
2929
import java.util.ArrayList;
3030
import java.util.List;
31+
import java.util.Objects;
3132

3233
public abstract class RunFlutterAction extends AnAction {
3334
private final @NotNull String myDetailedTextKey;
@@ -62,6 +63,7 @@ public void actionPerformed(@NotNull AnActionEvent e) {
6263
}
6364

6465
final SdkRunConfig sdkRunConfig = (SdkRunConfig)configuration.clone();
66+
assert sdkRunConfig != null;
6567
final SdkFields fields = sdkRunConfig.getFields();
6668
final String additionalArgs = fields.getAdditionalArgs();
6769

@@ -153,7 +155,8 @@ public static RunnerAndConfigurationSettings getRunConfigSettings(@Nullable AnAc
153155

154156
@Nullable
155157
public static Executor getExecutor(@NotNull String executorId) {
156-
for (Executor executor : Executor.EXECUTOR_EXTENSION_NAME.getExtensions()) {
158+
for (Executor executor : Objects.requireNonNull(Executor.EXECUTOR_EXTENSION_NAME.getExtensions())) {
159+
assert executor != null;
157160
if (executorId.equals(executor.getId())) {
158161
return executor;
159162
}

0 commit comments

Comments
 (0)