Fix log formatting in SnapshotLifecycleTask (elastic#136709) (elastic#136756)

While converting an error log from `logger.error` to
`logger.error(format())` in elastic#131646, we forgot to update the syntax from
`{}` to `%s`. This resulted in the logs `failed to create snapshot for
snapshot lifecycle policy [{}]`. This commit fixes the syntax and
ensures we use the right logger.

Author: nielsbauman

docs/changelog/136709.yaml

@@ -0,0 +1,5 @@
+pr: 136709
+summary: Fix log formatting in `SnapshotLifecycleTask`
+area: ILM+SLM
+type: bug
+issues: []

x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java

@@ -265,8 +265,9 @@ public void onFailure(Exception e) {
                 @Override
                 public void onFailure(Exception e) {
                     SnapshotHistoryStore.logErrorOrWarning(
+                        logger,
                         clusterService.state(),
-                        () -> format("failed to create snapshot for snapshot lifecycle policy [{}]", policyMetadata.getPolicy().getId()),
+                        () -> format("failed to create snapshot for snapshot lifecycle policy [%s]", policyMetadata.getPolicy().getId()),
                         e
                     );
                     final long timestamp = Instant.now().toEpochMilli();

x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/history/SnapshotHistoryStore.java

@@ -88,13 +88,15 @@ public void putAsync(SnapshotHistoryItem item) {
                 );
             },
                 exception -> logErrorOrWarning(
+                    logger,
                     clusterService.state(),
                     () -> format("failed to index snapshot history item in data stream [%s]: [%s]", SLM_HISTORY_DATA_STREAM, item),
                     exception
                 )
             ));
         } catch (IOException exception) {
             logErrorOrWarning(
+                logger,
                 clusterService.state(),
                 () -> format("failed to index snapshot history item in data stream [%s]: [%s]", SLM_HISTORY_DATA_STREAM, item),
                 exception
@@ -103,7 +105,7 @@ public void putAsync(SnapshotHistoryItem item) {
     }
 
     // On node shutdown, some operations are expected to fail, we log a warning instead of error during node shutdown for those exceptions
-    public static void logErrorOrWarning(ClusterState clusterState, Supplier<?> failureMsgSupplier, Exception exception) {
+    public static void logErrorOrWarning(Logger logger, ClusterState clusterState, Supplier<?> failureMsgSupplier, Exception exception) {
         if (PluginShutdownService.isLocalNodeShutdown(clusterState)) {
             logger.warn(failureMsgSupplier, exception);
         } else {