This repository was archived by the owner on Jul 21, 2024. It is now read-only.
Approved label added with 1 approval and 1 change request #244
Description
Summary
The approved label is added incorrectly when there is one approving review followed by one changes requested review.
Steps to reproduce
- Set up branch protections to require 1 (might not be relevant?)
- Request 2 reviews
- First reviewer approves the changes (should go to
PR: partially-approved, which occurs) - Second reviewer requests changes
Pull Request URL
Private repo unfortunately
What is the current bug behavior?
PR: reviewed-approved label is added
What is the expected correct behavior?
PR: reviewed-changes-requested label is added
Relevant logs and/or screenshots
Possible fixes
(If you have any idea to solve the problem, please help us.)
Most likely related to #223. I'm willing to take a crack at a PR in the future, but a little busy at the moment.