user balloon_eval for hover information #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabirshrestha
commented
Nov 23, 2017
| let g:lsp_loaded = 1 | ||
|
|
||
| let g:lsp_auto_enable = get(g:, 'lsp_auto_enable', 1) | ||
| let g:lsp_hover_balloon_eval = get(g:, 'lsp_hover_balloon_eval', has('balloon_eval')) |
There was a problem hiding this comment.
need to support this scenario. let g:lsp_hover_ui = 'echo,preview,balloon'
|
Please wait merge until fixed a bug that vim call API for balloon with free-ed pointer. |
|
Can you add a reference/link to the vim bug/discussion here for future reference. |
|
I confirmed two problems about tooltip. About No2, I don't confirm how to reproduce.
|
|
vim/vim#3708 was merged. |
|
One more vim/vim#3725 |
|
Now both patches are merged into Vim. |
|
You should want to enable balloonevalterm? |
|
We can check this in once we have the event queue and diff changes in. Would help reduce talking too much to the server. |
|
closing in favor of the new vim/neovim popup feature which also works in terminal and is more powerful than balloon. #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based of @mattn changes in https://github.com/mattn/vim-lsp-1/tree/balloon-eval