Skip to content

Commit f900d50

Browse files
ZacBlancopradeepvaka
authored andcommitted
Use java matrix for arrow-flight tests
1 parent 4324abe commit f900d50

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

.github/workflows/arrow-flight-tests.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,13 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22+
java: [ 8, 17.0.13 ]
2223
modules:
2324
- ":presto-base-arrow-flight" # Only run tests for the `presto-base-arrow-flight` module
2425

2526
timeout-minutes: 80
2627
concurrency:
27-
group: ${{ github.workflow }}-test-${{ matrix.modules }}-${{ github.event.pull_request.number }}
28+
group: ${{ github.workflow }}-test-${{ matrix.modules }}-${{ github.event.pull_request.number }}-${{ matrix.java }}
2829
cancel-in-progress: true
2930

3031
steps:
@@ -37,7 +38,7 @@ jobs:
3738
- uses: actions/setup-java@v4
3839
with:
3940
distribution: 'temurin'
40-
java-version: 8
41+
java-version: ${{ matrix.java }}
4142
cache: 'maven'
4243
- name: Download nodejs to maven cache
4344
run: .github/bin/download_nodejs

presto-base-arrow-flight/pom.xml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
<properties>
1616
<air.main.basedir>${project.parent.basedir}</air.main.basedir>
17+
<air.test.jvm.additional-arguments>-Xss10M</air.test.jvm.additional-arguments>
1718
</properties>
1819

1920
<dependencies>
@@ -220,13 +221,6 @@
220221

221222
<build>
222223
<plugins>
223-
<plugin>
224-
<groupId>org.apache.maven.plugins</groupId>
225-
<artifactId>maven-surefire-plugin</artifactId>
226-
<configuration>
227-
<argLine>-Xss10M</argLine>
228-
</configuration>
229-
</plugin>
230224
<plugin>
231225
<groupId>org.apache.maven.plugins</groupId>
232226
<artifactId>maven-enforcer-plugin</artifactId>
@@ -268,6 +262,7 @@
268262
</activation>
269263
<properties>
270264
<air.test.jvm.additional-arguments>
265+
-Xss10M
271266
--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED
272267
</air.test.jvm.additional-arguments>
273268
</properties>

0 commit comments

Comments
 (0)