PERF: value types end up boxed

[Therzok]

Given S, D value types here, when doing a.Equals(b), they end up using the Equals(object) overload.

Maybe it would be good to have EqualityComparer<T>.Default.Equals(a, b) there?

I initially wanted to suggest having S:IEquatable<D>, D:IEquatable<S>, There's also the problem when one of S values is null, since a.Equals(b) would NRE. I know that having nulls is bad design, but better safe than sorry?

[praeclarum]

Yes, you're absolutely right.

[praeclarum]

Shoot, I tried to implement this but it's a bit tricky since EqualityComparer<T> assumes a and b are the same type. I think it's best to advise people to write their own match functions to avoid boxing and handle nulls.

[Therzok]

Maybe add a version which constrains S and D to IEquatable for the other?