More error handling

Author: prateek147

DVIA-v2/DVIA-v2.xcworkspace/xcuserdata/prateek.xcuserdatad/UserInterfaceState.xcuserstate

@@ -31,6 +31,11 @@ class CoreDataViewController: UIViewController {
 
     @IBAction func saveInCoreDataTapped(_ sender: Any) {
 
+        if nameTextField.text?.isEmpty ?? true || emailTextField.text?.isEmpty ?? true || passwordTextField.text?.isEmpty ?? true || phoneTextField.text?.isEmpty ?? true {
+            DVIAUtilities.showAlert(title: "Error", message: "One or more input fields is empty.", viewController: self)
+            return
+        }
+        
         if #available(iOS 10.0, *) {
             let context = CoreDataStack.shared.persistentContainer.viewContext
             let newUser = NSEntityDescription.insertNewObject(forEntityName: "User", into: context) as? User

DVIA-v2/DVIA-v2/Vulnerabilities/Insecure Data Storage/Controller/CoreDataViewController.swift

@@ -26,6 +26,10 @@ class CouchbaseLiteViewController: UIViewController {
     }
 
     @IBAction func saveInCouchbaseTapped(_ sender: Any) {
+        if couchbaseUserName.text?.isEmpty ?? true || couchbasePassword.text?.isEmpty ?? true {
+            DVIAUtilities.showAlert(title: "Error", message: "One or more input fields is empty.", viewController: self)
+            return
+        }
         let database: CBLDatabase = try! CBLManager.sharedInstance().databaseNamed("dvcouchbasedb")
         guard let username = couchbaseUserName.text else { return }
         guard let password = couchbasePassword.text else { return }

DVIA-v2/DVIA-v2/Vulnerabilities/Insecure Data Storage/Controller/CouchbaseLiteViewController.swift

@@ -27,6 +27,10 @@ class KeychainViewController: UIViewController {
     }
 
     @IBAction func saveInKeychainTapped(_ sender: Any) {
+        if keychainTextField.text?.isEmpty ?? true {
+            DVIAUtilities.showAlert(title: "Error", message: "One or more input fields is empty.", viewController: self)
+            return
+        }
         let bindings = PDKeychainBindings.shared()
         bindings?.setObject(keychainTextField.text, forKey: "keychainValue")
         DVIAUtilities.showAlert(title: "", message: "Data saved in Keychain", viewController: self)

DVIA-v2/DVIA-v2/Vulnerabilities/Insecure Data Storage/Controller/KeychainViewController.swift

@@ -29,7 +29,10 @@ class PListViewController: UIViewController {
     }
 
     @IBAction func saveInPlistFileTapped(_ sender: Any) {
-       
+        if usernameTextField.text?.isEmpty ?? true || passwordTextField.text?.isEmpty ?? true {
+            DVIAUtilities.showAlert(title: "Error", message: "One or more input fields is empty.", viewController: self)
+            return
+        }
         func documentsDirectory() -> String {
             let paths = NSSearchPathForDirectoriesInDomains(.documentDirectory, .userDomainMask, true)
             let documentsDirectory = paths.first!

DVIA-v2/DVIA-v2/Vulnerabilities/Insecure Data Storage/Controller/PListViewController.swift

@@ -29,6 +29,10 @@ class RealmViewController: UIViewController {
     }
 
     @IBAction func saveInRealmTapped(_ sender: Any) {
+        if realmUserNameTextField.text?.isEmpty ?? true || realmPasswordTextField.text?.isEmpty ?? true {
+            DVIAUtilities.showAlert(title: "Error", message: "One or more input fields is empty.", viewController: self)
+            return
+        }
         let realm: Realm = try! Realm()
         let user = RealmUser()
         user.name = realmUserNameTextField.text

DVIA-v2/DVIA-v2/Vulnerabilities/Insecure Data Storage/Controller/RealmViewController.swift

@@ -27,6 +27,10 @@ class UserDefaultsViewController: UIViewController {
     }
 
     @IBAction func saveInUserDefaultsTapped(_ sender: Any) {
+        if userDefaultsTextField.text?.isEmpty ?? true {
+            DVIAUtilities.showAlert(title: "Error", message: "One or more input fields is empty.", viewController: self)
+            return
+        }
         let defaults: UserDefaults? = UserDefaults.standard
         defaults?.set(userDefaultsTextField.text, forKey: "DemoValue")
         defaults?.synchronize()

DVIA-v2/DVIA-v2/Vulnerabilities/Insecure Data Storage/Controller/UserDefaultsViewController.swift

@@ -30,6 +30,10 @@ class YapDatabaseViewController: UIViewController {
     }
 
     @IBAction func saveInYapDatabaseTapped(_ sender: Any) {
+        if yapDatabaseUsername.text?.isEmpty ?? true || yapDatabasePassword.text?.isEmpty ?? true {
+            DVIAUtilities.showAlert(title: "Error", message: "One or more input fields is empty.", viewController: self)
+            return
+        }
         let databaseName = "YapDatabase.sqlite"
         let baseUrl = try! FileManager.default.url(for: .applicationSupportDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
         let databaseUrl = baseUrl.appendingPathComponent(databaseName, isDirectory: false)

DVIA-v2/DVIA-v2/Vulnerabilities/Insecure Data Storage/Controller/YapDatabaseViewController.swift

@@ -15,13 +15,17 @@
 
 import UIKit
 
-class AppScreenshotViewController: UIViewController {
+class AppScreenshotViewController: UIViewController, UITextFieldDelegate {
 
     override func viewDidLoad() {
         super.viewDidLoad()
         self.navigationItem.title = "App Screenshot"
         // Do any additional setup after loading the view.
     }
-
+    
+    func textFieldShouldReturn(_ textField: UITextField) -> Bool {
+        textField.resignFirstResponder()
+        return true
+    }
 
 }

DVIA-v2/DVIA-v2/Vulnerabilities/Side Channel Data Leakage/Controller/AppScreenshotViewController.swift

@@ -52,8 +52,7 @@ extension CookiesViewController: UITextFieldDelegate {
         textField.resignFirstResponder()
         return true
     }
-    
-    
+
     func setSharedCookies() {
 
         var components = DateComponents()