Making 'changes' a set to ensure unique values

Author: aasthabharill

assessment/report_generator.go

@@ -523,15 +523,15 @@ func calculateTableDbChangesAndImpact(tableAssessment utils.TableAssessment) (st
 }
 
 func calculateColumnDbChangesAndImpact(columnAssessment utils.ColumnAssessment) (string, string, string, *[]string) {
-	changes := []string{}
+	changesMap := make(map[string]bool)
 	impact := []string{}
 	changeEffort := "Automatic"
 	actionItems := []string{}
 	if !columnAssessment.CompatibleDataType { // TODO type specific checks on size
-		changes = append(changes, "type")
+		changesMap["type"] = true
 	}
 	if columnAssessment.SourceColDef.IsOnUpdateTimestampSet { //TODO Add Code change effort for this
-		changes = append(changes, "feature")
+		changesMap["feature"] = true
 		changeEffort = "None"
 		actionItems = append(actionItems, "Update queries to include PENDING_COMMIT_TIMESTAMP")
 	}
@@ -541,7 +541,7 @@ func calculateColumnDbChangesAndImpact(columnAssessment utils.ColumnAssessment)
 		case "NULL":
 			//Nothing to do - equivalent
 		default:
-			changes = append(changes, "feature")
+			changesMap["feature"] = true
 			changeEffort = "Small"
 			actionItems = append(actionItems, "Alter column to apply default value")
 		}
@@ -559,7 +559,7 @@ func calculateColumnDbChangesAndImpact(columnAssessment utils.ColumnAssessment)
 	}
 
 	if columnAssessment.SourceColDef.AutoGen.Name != "" && columnAssessment.SourceColDef.AutoGen.GenerationType == constants.AUTO_INCREMENT {
-		changes = append(changes, "feature")
+		changesMap["feature"] = true
 	}
 	if columnAssessment.SourceColDef.GeneratedColumn.IsPresent {
 		changeEffort = "Small"
@@ -568,6 +568,11 @@ func calculateColumnDbChangesAndImpact(columnAssessment utils.ColumnAssessment)
 
 	//TODO add check for not null to null scenarios
 
+	changes := []string{}
+	for k := range changesMap {
+		changes = append(changes, k)
+	}
+
 	if len(changes) == 0 {
 		changes = append(changes, "None")
 	}