REF is partially broken for TU4. (Both RSZ dump & C# API generation cause crashes.)

[Synthlight]

Describe the bug
A clear and concise description of what the bug is. If the bug only started to happen after a certain REFramework update, let us know which version the bug appeared in.

• Dumping IL2CPP json crashes about 2 seconds into the "Dumping RSZ".
• Others have reported that the game crashes as soon as ultra-wide support is enabled.
• C# API generation causes the game to crash very early on in generation.
• Corrupt PAK check still works, but the game completely ignores PAK patch files that are above the vanilla count.
  • i.e. If the last vanilla patch is 13, patch PAKs 14+ are never loaded. (This happens with or without REF.) I'm not sure if the game somehow skims over them and decides not to but:
  • If I replace a vanilla patch PAK with a modded one, the game does load it, and it is corrupt, as expected, without REF to patch the check. (And REF still does patch this check correctly.)
  • Noe being able to load custom additional PAKs currently prevents any mods with textures from loading.

Upload logs and any crash dumps
These are after launching the game and pressing the button to dump RSZ json:
re2_framework_log.zip
reframework_crash.zip

And these are with the C# API generation like 10 seconds after launching the game:
re2_framework_log.zip
(This does not produce an updated crash dump.)

Identify the REFramework version
Nightly 1204 3227102
Also tried with the older 76520ca build, merged into the C# API branch locally.

To Reproduce
Either run REF with the C# API for generation.
Or just click the RSZ json dump button.

Expected behavior
I expect C# API to generate successfully, and the RSZ json to dump successfully.

Screenshots
A crash of specifically the C# API generation:

Desktop and VR (please complete the following information):

• Win 10 LTSC 21H2
• GTX 3090Ti
• 13900KF

[Synthlight]

According to dtlnor, the current TDB version is 81, so hopefully that's the sole cause of the issues.

[misutime]

Same issue here. I compared our re2_framework_log files and the error messages are identical.

[hcdd0304]

I did manage to fix some stuffs, getting il2cpp dump, rsz dump and pak loading works okay (though the change is very questionable). But I also saw @praydog is working on it, so I will put my code here in case it helps: link

Ready to use build here

[Synthlight]

As of ccc8f91 (nightly 1208), lots of things are fixed:

• Ultra-wide is fixed.
• FreeCam is fixed.
• LUA lag issues are fixed.
• RSZ dumping / generation is fixed.
• PAKs past the vanilla count are now loaded.

Things still not working:

• C# API gen still fails.

Great work so far @praydog! I cannot thank you enough for what you do here!

@hcdd0304 Thanks for the temp fixes. I couldn't get RSZ generation working with it, but I appreciate it nonetheless.

[Synthlight]

I did manage to fix some stuffs, getting il2cpp dump, rsz dump and pak loading works okay (though the change is very questionable). But I also saw @praydog is working on it, so I will put my code here in case it helps: link

Ready to use build here

I suggest you make a PR off current master to just include the PAK loading fix. praydog's on vacay, and it's better than nothing till they're back.

[hcdd0304]

I put it up. New code should affect only the MHWilds version of REFramework for now. See #1473

[Synthlight]

So I see the C# API updated: 81403f4
It's running into the same issues I was though. (I'd been working with master merged into it.)

The console log is too long to even copy the whole things, and I'm not sure it even winds up in the REF log, so here's the log and what I could copy from the console:
(Note: This is from me using REF builds on the C# API, but with the missing PAK fix commit merged into it.)
re2_framework_log.txt
c#-api.log (This is what I could copy from the console.)

There winds up being a lot of stuff like this:

Error in line 3: publicinterfaceMath:global::_System.Object{[global::REFrameworkNET.Attributes.Method(898804, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoubleCeiling(doublearg0){return (double)INTERNAL_Ceiling898804.InvokeBoxed(typeof(double), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898805, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoubleCos(doublearg0){return (double)INTERNAL_Cos898805.InvokeBoxed(typeof(double), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898806, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoubleFloor(doublearg0){return (double)INTERNAL_Floor898806.InvokeBoxed(typeof(double), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898807, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoublePow(doublearg0,doublearg1){return (double)INTERNAL_Pow898807.InvokeBoxed(typeof(double), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898808, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoubleSin(doublearg0){return (double)INTERNAL_Sin898808.InvokeBoxed(typeof(double), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898809, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoubleSqrt(doublearg0){return (double)INTERNAL_Sqrt898809.InvokeBoxed(typeof(double), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898810, global::REFrameworkNET.FieldFacadeType.None)]publicstaticintAbs(intarg0){return (int)INTERNAL_Abs898810.InvokeBoxed(typeof(int), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898811, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoubleAbs(doublearg0){return (double)INTERNAL_Abs898811.InvokeBoxed(typeof(double), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898812, global::REFrameworkNET.FieldFacadeType.None)]publicstaticfloatAbs(floatarg0){return (float)INTERNAL_Abs898812.InvokeBoxed(typeof(float), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898813, global::REFrameworkNET.FieldFacadeType.None)]publicstaticulongBigMul(ulongarg0,ulongarg1,refulongarg2){return (ulong)INTERNAL_BigMul898813.InvokeBoxed(typeof(ulong), null, new object[] {arg0, arg1, arg2});}[global::REFrameworkNET.Attributes.Method(898814, global::REFrameworkNET.FieldFacadeType.None)]publicstaticobjectDivRem(uintarg0,uintarg1){return (object)INTERNAL_DivRem898814.InvokeBoxed(typeof(object), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898815, global::REFrameworkNET.FieldFacadeType.None)]publicstaticobjectDivRem(ulongarg0,ulongarg1){return (object)INTERNAL_DivRem898815.InvokeBoxed(typeof(object), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898816, global::REFrameworkNET.FieldFacadeType.None)]publicstaticintClamp(intarg0,intarg1,intarg2){return (int)INTERNAL_Clamp898816.InvokeBoxed(typeof(int), null, new object[] {arg0, arg1, arg2});}[global::REFrameworkNET.Attributes.Method(898817, global::REFrameworkNET.FieldFacadeType.None)]publicstaticfloatClamp(floatarg0,floatarg1,floatarg2){return (float)INTERNAL_Clamp898817.InvokeBoxed(typeof(float), null, new object[] {arg0, arg1, arg2});}[global::REFrameworkNET.Attributes.Method(898818, global::REFrameworkNET.FieldFacadeType.None)]publicstaticuintClamp(uintarg0,uintarg1,uintarg2){return (uint)INTERNAL_Clamp898818.InvokeBoxed(typeof(uint), null, new object[] {arg0, arg1, arg2});}[global::REFrameworkNET.Attributes.Method(898819, global::REFrameworkNET.FieldFacadeType.None)]publicstaticintMax(intarg0,intarg1){return (int)INTERNAL_Max898819.InvokeBoxed(typeof(int), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898820, global::REFrameworkNET.FieldFacadeType.None)]publicstaticlongMax(longarg0,longarg1){return (long)INTERNAL_Max898820.InvokeBoxed(typeof(long), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898821, global::REFrameworkNET.FieldFacadeType.None)]publicstaticfloatMax(floatarg0,floatarg1){return (float)INTERNAL_Max898821.InvokeBoxed(typeof(float), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898822, global::REFrameworkNET.FieldFacadeType.None)]publicstaticuintMax(uintarg0,uintarg1){return (uint)INTERNAL_Max898822.InvokeBoxed(typeof(uint), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898823, global::REFrameworkNET.FieldFacadeType.None)]publicstaticshortMin(shortarg0,shortarg1){return (short)INTERNAL_Min898823.InvokeBoxed(typeof(short), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898824, global::REFrameworkNET.FieldFacadeType.None)]publicstaticintMin(intarg0,intarg1){return (int)INTERNAL_Min898824.InvokeBoxed(typeof(int), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898825, global::REFrameworkNET.FieldFacadeType.None)]publicstaticfloatMin(floatarg0,floatarg1){return (float)INTERNAL_Min898825.InvokeBoxed(typeof(float), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898826, global::REFrameworkNET.FieldFacadeType.None)]publicstaticuintMin(uintarg0,uintarg1){return (uint)INTERNAL_Min898826.InvokeBoxed(typeof(uint), null, new object[] {arg0, arg1});}[global::REFrameworkNET.Attributes.Method(898827, global::REFrameworkNET.FieldFacadeType.None)]publicstaticdoubleRound(doublearg0){return (double)INTERNAL_Round898827.InvokeBoxed(typeof(double), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898828, global::REFrameworkNET.FieldFacadeType.None)]publicstaticintSign(intarg0){return (int)INTERNAL_Sign898828.InvokeBoxed(typeof(int), null, new object[] {arg0});}[global::REFrameworkNET.Attributes.Method(898829, global::REFrameworkNET.FieldFacadeType.None)]publicstaticintSign(floatarg0){return (int)INTERNAL_Sign898829.InvokeBoxed(typeof(int), null, new object[] {arg0});}publicstaticreadonlynewglobal::REFrameworkNET.TypeDefinitionREFType=global::REFrameworkNET.TDB.Get().FindType("System.Math");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Ceiling898804=REFType.GetMethod("Ceiling(System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Cos898805=REFType.GetMethod("Cos(System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Floor898806=REFType.GetMethod("Floor(System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Pow898807=REFType.GetMethod("Pow(System.Double, System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Sin898808=REFType.GetMethod("Sin(System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Sqrt898809=REFType.GetMethod("Sqrt(System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Abs898810=REFType.GetMethod("Abs(System.Int32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Abs898811=REFType.GetMethod("Abs(System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Abs898812=REFType.GetMethod("Abs(System.Single)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_BigMul898813=REFType.GetMethod("BigMul(System.UInt64, System.UInt64, System.UInt64)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_DivRem898814=REFType.GetMethod("DivRem(System.UInt32, System.UInt32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_DivRem898815=REFType.GetMethod("DivRem(System.UInt64, System.UInt64)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Clamp898816=REFType.GetMethod("Clamp(System.Int32, System.Int32, System.Int32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Clamp898817=REFType.GetMethod("Clamp(System.Single, System.Single, System.Single)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Clamp898818=REFType.GetMethod("Clamp(System.UInt32, System.UInt32, System.UInt32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Max898819=REFType.GetMethod("Max(System.Int32, System.Int32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Max898820=REFType.GetMethod("Max(System.Int64, System.Int64)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Max898821=REFType.GetMethod("Max(System.Single, System.Single)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Max898822=REFType.GetMethod("Max(System.UInt32, System.UInt32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Min898823=REFType.GetMethod("Min(System.Int16, System.Int16)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Min898824=REFType.GetMethod("Min(System.Int32, System.Int32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Min898825=REFType.GetMethod("Min(System.Single, System.Single)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Min898826=REFType.GetMethod("Min(System.UInt32, System.UInt32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Round898827=REFType.GetMethod("Round(System.Double)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Sign898828=REFType.GetMethod("Sign(System.Int32)");privatestaticreadonlyglobal::REFrameworkNET.MethodINTERNAL_Sign898829=REFType.GetMethod("Sign(System.Single)");}}
CS0234: The type or namespace name 'Object' does not exist in the namespace '_System' (are you missing an assembly reference?)

(Line 2 repeats a lot, line 1 is mostly always a bit different; a different type.)

[Synthlight]

As #1483 has been closed as fixed, that was the last straggler here, so I'm closing this as well.