chore: cleanup test

Author: prdktntwcklr

tests/test-button.robot

@@ -1,32 +1,42 @@
-# Filename: test-button.robot
 *** Settings ***
 Suite Setup                   Setup
 Suite Teardown                Teardown
-Test Setup                    Reset Emulation
+Test Setup                    Reset And Load System
 Resource                      ${RENODEKEYWORDS}
 
+*** Variables ***
+${REPL}                       ${CURDIR}/../nucleo_f446re_custom.repl
+${ELF}                        ${CURDIR}/../nucleo-f446re/ButtonLed/build/ButtonLed.elf
+${LED}                        sysbus.gpioa.greenled2
+${BUTTON}                     sysbus.gpioc.bluebutton
+
 *** Test Cases ***
 Button Press should Toggle LED
-    Execute Command         mach create
-    Execute Command         machine LoadPlatformDescription @${CURDIR}/../nucleo_f446re_custom.repl
-    Execute Command         sysbus LoadELF @${CURDIR}/../nucleo-f446re/ButtonLed/build/ButtonLed.elf
+    [Documentation]           Verifies that the LED toggles its state on every
+    ...                       button click.
 
-    Start Emulation
-    
-    ${LedState}=  Execute Command  sysbus.gpioa.greenled2 State
-    Should Be Equal         ${LedState.strip()}    False
-    
-    Execute Command         sysbus.gpioc.bluebutton Press
-    sleep                   100milliseconds
-    Execute Command         sysbus.gpioc.bluebutton Release
+    LED State Should Be       False
 
-    ${LedState}=  Execute Command  sysbus.gpioa.greenled2 State
-    Should Be Equal         ${LedState.strip()}    True
+    Toggle Button
+    LED State Should Be       True
+
+    Toggle Button
+    LED State Should Be       False
+
+*** Keywords ***
+Reset And Load System
+    Reset Emulation
+    Execute Command         mach create
+    Execute Command         machine LoadPlatformDescription @${REPL}
+    Execute Command         sysbus LoadELF @${ELF}
+    Start Emulation
 
-    Execute Command         sysbus.gpioc.bluebutton Press
-    sleep                   100milliseconds
-    Execute Command         sysbus.gpioc.bluebutton Release
+Toggle Button
+    Execute Command           ${BUTTON} Press
+    Sleep                     100ms    # Small delay for debouncing logic in firmware
+    Execute Command           ${BUTTON} Release
 
-    ${LedState}=  Execute Command  sysbus.gpioa.greenled2 State
-    Should Be Equal         ${LedState.strip()}    False
- 
+LED State Should Be
+    [Arguments]               ${expected_state}
+    ${current_state}=         Execute Command    ${LED} State
+    Should Be Equal           ${current_state.strip()}    ${expected_state}