Skip to content

Commit 3879bbc

Browse files
committed
Fix spotless setup
1 parent d225ca7 commit 3879bbc

File tree

2 files changed

+31
-27
lines changed

2 files changed

+31
-27
lines changed

.github/workflows/build-and-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ jobs:
3030
# First version is for Bosk to use, and the second is for Gradle
3131
java-version: |
3232
25
33-
17
33+
25
3434
35-
- uses: gradle/actions/setup-gradle@v4
35+
- uses: gradle/actions/setup-gradle@v5
3636
with:
3737
cache-read-only: false # OR: ${{ github.ref != 'refs/heads/develop' }}
3838

build.gradle

Lines changed: 29 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -138,32 +138,36 @@ configure(subprojects.findAll { it.name.startsWith("bosk-") || it.name == "boson
138138
}
139139
}
140140

141-
// TODO: Spotless currently isn't doing anything and I can't figure out why
142-
spotless {
143-
enforceCheck = false
144-
java {
145-
importOrder '', '\\#' // Static imports after regular imports, as per mt-server standard and IntelliJ default
146-
removeUnusedImports()
147-
trimTrailingWhitespace()
148-
leadingSpacesToTabs()
149-
replaceRegex 'class-level javadoc indentation fix', /^\*/, ' *'
150-
replaceRegex 'method-level javadoc indentation fix', /\t\*/, '\t *'
151-
}
152-
format 'gradle', {
153-
target '**/*.gradle'
141+
// Spotless configuration
142+
subprojects {
143+
apply plugin: 'com.diffplug.spotless'
144+
spotless {
145+
java {
146+
importOrder '', '\\#' // Static imports after regular imports, as per mt-server standard and IntelliJ default
147+
removeUnusedImports()
148+
expandWildcardImports()
149+
forbidModuleImports()
150+
trimTrailingWhitespace()
151+
leadingSpacesToTabs()
152+
replaceRegex 'class-level javadoc indentation fix', /^\*/, ' *'
153+
replaceRegex 'method-level javadoc indentation fix', /\t\*/, '\t *'
154+
}
155+
format 'gradle', {
156+
target '**/*.gradle'
154157

155-
trimTrailingWhitespace()
156-
leadingSpacesToTabs()
157-
endWithNewline()
158-
}
159-
format 'misc', {
160-
target '**/*.md', '**/.gitignore'
161-
162-
trimTrailingWhitespace()
163-
//leadingSpacesToTabs() For markdown, we want to align some code examples very carefully, so we use spaces
164-
replaceRegex 'class-level javadoc indentation fix', /^\*/, ' *'
165-
replaceRegex 'method-level javadoc indentation fix', /\t\*/, '\t *'
166-
endWithNewline()
158+
trimTrailingWhitespace()
159+
leadingSpacesToTabs()
160+
endWithNewline()
161+
}
162+
format 'misc', {
163+
target '**/*.md', '**/.gitignore'
164+
165+
trimTrailingWhitespace()
166+
//leadingSpacesToTabs() For markdown, we want to align some code examples very carefully, so we use spaces
167+
replaceRegex 'class-level javadoc indentation fix', /^\*/, ' *'
168+
replaceRegex 'method-level javadoc indentation fix', /\t\*/, '\t *'
169+
endWithNewline()
170+
}
167171
}
168172
}
169173

0 commit comments

Comments
 (0)