Skip to content

Commit 42226ab

Browse files
committed
Reduce warnings
1 parent 738abf3 commit 42226ab

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

bosk-jackson/src/main/java/works/bosk/jackson/JsonNodeDriver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public synchronized <T> void submitReplacement(Reference<T> target, T newValue)
5959
@Override
6060
public synchronized <T> void submitConditionalReplacement(Reference<T> target, T newValue, Reference<Identifier> precondition, Identifier requiredValue) {
6161
traceCurrentState("Before submitConditionalReplacement");
62-
if (requiredValue.toString().equals(surgeon.valueNode(currentRoot, precondition).textValue())) {
62+
if (requiredValue.toString().equals(surgeon.valueNode(currentRoot, precondition).asString())) {
6363
doReplacement(surgeon.nodeInfo(currentRoot, target), target.path().lastSegment(), newValue);
6464
}
6565
downstream.submitConditionalReplacement(target, newValue, precondition, requiredValue);
@@ -87,7 +87,7 @@ public synchronized <T> void submitDeletion(Reference<T> target) {
8787
@Override
8888
public synchronized <T> void submitConditionalDeletion(Reference<T> target, Reference<Identifier> precondition, Identifier requiredValue) {
8989
traceCurrentState("Before submitConditionalDeletion");
90-
if (requiredValue.toString().equals(surgeon.valueNode(currentRoot, precondition).textValue())) {
90+
if (requiredValue.toString().equals(surgeon.valueNode(currentRoot, precondition).asString())) {
9191
surgeon.deleteNode(surgeon.nodeInfo(currentRoot, target));
9292
}
9393
downstream.submitConditionalDeletion(target, precondition, requiredValue);

bosk-mongo/src/main/java/works/bosk/drivers/mongo/status/ManifestStatus.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,18 @@
11
package works.bosk.drivers.mongo.status;
22

3+
import works.bosk.StateTreeNode;
34
import works.bosk.drivers.mongo.internal.Manifest;
45

56
public record ManifestStatus(
6-
Manifest expected,
7-
Manifest actual
7+
StateTreeNode expected,
8+
StateTreeNode actual
89
) {
10+
public ManifestStatus {
11+
// These should be Manifest objects, but we don't want to export that type from this module
12+
assert expected instanceof Manifest;
13+
assert actual instanceof Manifest;
14+
}
15+
916
public boolean isIdentical() {
1017
return expected.equals(actual);
1118
}

bosk-mongo/src/main/java/works/bosk/drivers/mongo/status/MongoStatus.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package works.bosk.drivers.mongo.status;
22

33
import com.fasterxml.jackson.annotation.JsonInclude;
4+
import works.bosk.StateTreeNode;
45
import works.bosk.drivers.mongo.MongoDriverSettings.DatabaseFormat;
56
import works.bosk.drivers.mongo.internal.Manifest;
67

@@ -15,7 +16,7 @@ public record MongoStatus(
1516
ManifestStatus manifest,
1617
StateStatus state
1718
) {
18-
public MongoStatus with(DatabaseFormat preferredFormat, Manifest actualManifest) {
19+
public MongoStatus with(DatabaseFormat preferredFormat, StateTreeNode actualManifest) {
1920
return new MongoStatus(
2021
this.error,
2122
new ManifestStatus(

0 commit comments

Comments
 (0)