Skip to content

Commit 7081640

Browse files
committed
Module tweaks to reduce warnings
1 parent cfa50f7 commit 7081640

File tree

8 files changed

+18
-15
lines changed

8 files changed

+18
-15
lines changed

bosk-core/src/main/java/module-info.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
module works.bosk.core {
2-
requires org.jetbrains.annotations;
2+
requires transitive org.jetbrains.annotations;
33
requires org.objectweb.asm;
44
requires org.objectweb.asm.util;
55
requires org.pcollections;
66
requires org.slf4j;
7-
requires works.bosk.annotations;
7+
requires transitive works.bosk.annotations;
88

99
requires static lombok;
1010

bosk-jackson/src/main/java/module-info.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
module works.bosk.jackson {
2-
requires com.fasterxml.jackson.core;
3-
requires com.fasterxml.jackson.databind;
2+
requires transitive com.fasterxml.jackson.core;
3+
requires transitive com.fasterxml.jackson.databind;
44
requires org.slf4j;
5-
requires works.bosk.core;
5+
requires transitive works.bosk.core;
66

77
requires static lombok;
88

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
module works.bosk.logback {
2-
requires ch.qos.logback.classic;
3-
requires ch.qos.logback.core;
4-
requires org.slf4j;
5-
requires works.bosk.core;
2+
requires transitive ch.qos.logback.classic;
3+
requires transitive ch.qos.logback.core;
4+
requires transitive org.slf4j;
5+
requires transitive works.bosk.core;
6+
67
exports works.bosk.logback;
78
}

bosk-mongo/src/main/java/module-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
requires org.mongodb.bson;
44
requires org.mongodb.driver.core;
55
requires org.slf4j;
6-
requires works.bosk.core;
6+
requires transitive works.bosk.core;
77

88
requires static lombok;
99

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module works.bosk.opentelemetry {
22
requires io.opentelemetry.api;
33
requires io.opentelemetry.context;
4-
requires works.bosk.core;
4+
requires transitive works.bosk.core;
55

66
exports works.bosk.opentelemetry;
77
}

bosk-spring-boot/src/main/java/module-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
requires spring.boot;
77
requires spring.context;
88
requires spring.web;
9-
requires works.bosk.core;
9+
requires transitive works.bosk.core;
1010
requires works.bosk.jackson;
1111

1212
requires static lombok;

bosk-sql/src/main/java/module-info.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
module works.bosk.sql {
2-
requires com.fasterxml.jackson.databind;
3-
requires org.jooq;
2+
requires transitive com.fasterxml.jackson.databind; // This really shouldn't be transitive
3+
requires transitive org.jooq;
44
requires org.slf4j;
5-
requires works.bosk.core;
5+
requires transitive works.bosk.core;
66
requires works.bosk.jackson;
77

88
exports works.bosk.drivers.sql;

build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ configure(subprojects.findAll {
5656
options.compilerArgs << '-Xlint:-serial' // Don't care about Java serialization
5757
options.compilerArgs << '-Xlint:-try' // Really annoying bogus "auto-closeable never used" warnings
5858
options.compilerArgs << '-Xlint:-processing' // Not all annotations are meant for compile-time "annotation processing"
59+
options.compilerArgs << '-Xlint:-missing-explicit-ctor' // We probably ought to fix this instead of suppressing it
60+
options.compilerArgs << '-Xlint:-module' // We probably ought to fix this instead of suppressing it
5961
options.forkOptions.jvmArgs << '--sun-misc-unsafe-memory-access=allow' // For Lombok
6062
}
6163

0 commit comments

Comments
 (0)