Various minor cleanups

Author: prdoyle

bosk-core/src/main/java/works/bosk/Catalog.java

@@ -1,6 +1,5 @@
 package works.bosk;
 
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Iterator;
 import java.util.LinkedHashMap;
@@ -14,7 +13,6 @@
 
 import static java.util.Arrays.asList;
 import static java.util.Collections.unmodifiableCollection;
-import static java.util.Collections.unmodifiableList;
 import static java.util.Collections.unmodifiableMap;
 import static java.util.LinkedHashMap.newLinkedHashMap;
 import static java.util.Objects.requireNonNull;
@@ -52,7 +50,7 @@ public E get(Identifier key) {
 
 	@Override
 	public List<Identifier> ids() {
-		return unmodifiableList(new ArrayList<>(contents.keySet()));
+		return List.copyOf(contents.keySet());
 	}
 
 	/**

bosk-core/src/main/java/works/bosk/Listing.java

@@ -120,7 +120,7 @@ public Listing<E> withoutEntity(E entity) {
 	@Override
 	public Iterator<Reference<E>> iterator() {
 		Iterator<Identifier> idIter = ids.iterator();
-		return new Iterator<Reference<E>>() {
+		return new Iterator<>() {
 			@Override
 			public boolean hasNext() {
 				return idIter.hasNext();
@@ -170,7 +170,7 @@ public Iterable<E> values() {
 		// we know a Listing qualifies for Spliterator.IMMUTABLE. And let's give
 		// a nice toString too, for debugging.
 		AddressableByIdentifier<E> domain = this.domain.value();
-		return new Iterable<E>() {
+		return new Iterable<>() {
 			@Override
 			public Iterator<E> iterator() {
 				return valueIteratorImpl(domain);
@@ -248,9 +248,16 @@ public Listing<E> filteredBy(Listing<E> other) {
 
 	private Iterator<E> valueIteratorImpl(AddressableByIdentifier<E> domain) {
 		Iterator<Identifier> iter = ids.iterator();
-		return new Iterator<E>() {
-			@Override public boolean hasNext() { return iter.hasNext(); }
-			@Override public E next() { return getOrThrow(domain, iter.next()); }
+		return new Iterator<>() {
+			@Override
+			public boolean hasNext() {
+				return iter.hasNext();
+			}
+
+			@Override
+			public E next() {
+				return getOrThrow(domain, iter.next());
+			}
 		};
 	}
 

bosk-core/src/main/java/works/bosk/Path.java

@@ -152,7 +152,7 @@ public final Path then(List<String> segments) {
 		if (segments.isEmpty()) {
 			return this;
 		} else {
-			String firstSegment = validSegment(segments.get(0));
+			String firstSegment = validSegment(segments.getFirst());
 			if (isParameterSegment(firstSegment)) {
 				if (segmentStream().anyMatch(firstSegment::equals)) {
 					throw new MalformedPathException("Duplicate path parameter \"" + firstSegment + "\"");

bosk-core/src/main/java/works/bosk/ReferenceUtils.java

@@ -284,7 +284,7 @@ public static <T> Constructor<T> theOnlyConstructorFor(Class<T> nodeClass) {
 			throw new IllegalArgumentException("Ambiguous constructor list for " + nodeClass.getSimpleName() + ": " + constructors);
 		}
 		@SuppressWarnings("unchecked")
-		Constructor<T> theConstructor = (Constructor<T>) constructors.get(0);
+		Constructor<T> theConstructor = (Constructor<T>) constructors.getFirst();
 		return theConstructor;
 	}
 

bosk-core/src/main/java/works/bosk/SideTable.java

@@ -1,7 +1,6 @@
 package works.bosk;
 
 import java.util.AbstractMap.SimpleImmutableEntry;
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -21,7 +20,6 @@
 import org.pcollections.OrderedPMap;
 import org.pcollections.OrderedPSet;
 
-import static java.util.Collections.unmodifiableList;
 import static java.util.Objects.requireNonNull;
 
 @EqualsAndHashCode
@@ -39,7 +37,7 @@ public final class SideTable<K extends Entity, V> implements EnumerableByIdentif
 
 	public boolean isEmpty() { return valuesById.isEmpty(); }
 	public int size() { return valuesById.size(); }
-	public List<Identifier> ids() { return unmodifiableList(new ArrayList<>(valuesById.keySet())); }
+	public List<Identifier> ids() { return List.copyOf(valuesById.keySet()); }
 	public Listing<K> keys() { return new Listing<>(domain, OrderedPSet.from(valuesById.keySet())); }
 	public Collection<V> values() { return valuesById.values(); }
 	public Set<Entry<Identifier, V>> idEntrySet() { return valuesById.entrySet(); }

bosk-mongo/src/main/java/works/bosk/drivers/mongo/internal/BsonSurgeon.java

@@ -224,7 +224,7 @@ public BsonDocument gather(List<BsonDocument> partsList) {
 
 		Set<BsonString> alreadySeen = new HashSet<>();
 
-		BsonDocument rootRecipe = partsList.get(0);
+		BsonDocument rootRecipe = partsList.getFirst();
 		List<String> prefix = bsonPathSegments(rootRecipe.getString(BSON_PATH_FIELD));
 
 		BsonDocument whole = rootRecipe.getDocument(STATE_FIELD);
@@ -237,7 +237,7 @@ public BsonDocument gather(List<BsonDocument> partsList) {
 			if (!bsonSegments.subList(0, prefix.size()).equals(prefix)) {
 				throw new IllegalArgumentException("Part doc is not contained within the root doc. Part: " + bsonSegments + " Root:" + prefix);
 			}
-			String key = bsonSegments.get(bsonSegments.size()-1);
+			String key = bsonSegments.getLast();
 			BsonValue value = requireNonNull(entry.get(STATE_FIELD));
 
 			BsonDocument container = lookup(whole, bsonSegments.subList(prefix.size(), bsonSegments.size() - 1));

bosk-mongo/src/main/java/works/bosk/drivers/mongo/internal/PandoFormatDriver.java

@@ -203,7 +203,7 @@ BsonState loadBsonState() throws UninitializedCollectionException {
 		} catch (NoSuchElementException e) {
 			throw new UninitializedCollectionException("No existing document", e);
 		}
-		BsonDocument mainPart = allParts.get(allParts.size()-1);
+		BsonDocument mainPart = allParts.getLast();
 		if (!ROOT_DOCUMENT_ID.equals(mainPart.get("_id"))) {
 			throw new IllegalStateException("Cannot locate root document");
 		}
@@ -288,7 +288,7 @@ private boolean isFinalEventOfTransaction(ChangeStreamDocument<BsonDocument> eve
 	}
 
 	private void processTransaction(List<ChangeStreamDocument<BsonDocument>> events) throws UnprocessableEventException {
-		ChangeStreamDocument<BsonDocument> finalEvent = events.get(events.size() - 1);
+		ChangeStreamDocument<BsonDocument> finalEvent = events.getLast();
 		switch (finalEvent.getOperationType()) {
 			case INSERT: case REPLACE: {
 				BsonDocument fullDocument = finalEvent.getFullDocument();

bosk-mongo/src/main/java/works/bosk/drivers/mongo/status/BsonComparator.java

@@ -18,7 +18,7 @@ public Difference difference(BsonValue expected, BsonValue actual) {
 			var differences = findSomeDifferences(expectedDoc, actualDoc);
 			return switch (differences.size()) {
 				case 0 -> new NoDifference();
-				case 1 -> differences.get(0);
+				case 1 -> differences.getFirst();
 				default -> {
 					// To prevent exponential fan-out, permit only max one compound inside another compound
 					int numCompounds = 0;

bosk-testing/src/main/java/works/bosk/testing/junit/ParametersByNameContextProvider.java

@@ -82,7 +82,7 @@ private List<String> allParameterNames(ExtensionContext context) {
 			case 0:
 				break;
 			case 1:
-				Collections.addAll(parameters, annotatedConstructors.get(0).getParameters());
+				Collections.addAll(parameters, annotatedConstructors.getFirst().getParameters());
 				break;
 			default:
 				throw new ParameterResolutionException("Multiple constructors annotated with " + ParametersByName.class.getSimpleName() + ": " + annotatedConstructors);
@@ -121,13 +121,9 @@ private Stream<?> invokeCorrespondingMethod(String name, Class<?> testClass) {
 		return result;
 	}
 
-	private static class ParameterBinder implements ParameterResolver {
-		private final Map<String, ?> binding;
-
-		public ParameterBinder(Map<String, ?> binding) {
-			this.binding = binding;
-		}
-
+	private record ParameterBinder(
+		Map<String, ?> binding
+	) implements ParameterResolver {
 		@Override
 		public boolean supportsParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException {
 			return binding.containsKey(parameterContext.getParameter().getName());