Skip to content

Commit 2f71f6f

Browse files
authored
Fix resource leak in CrossClusterSearchUnavailableClusterIT (elastic#124880) (elastic#124908)
Fixes elastic#123814
1 parent b9cd51f commit 2f71f6f

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

qa/ccs-unavailable-clusters/src/javaRestTest/java/org/elasticsearch/search/CrossClusterSearchUnavailableClusterIT.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,12 @@ private static MockTransportService startTransport(
9494
EsExecutors.DIRECT_EXECUTOR_SERVICE,
9595
SearchShardsRequest::new,
9696
(request, channel, task) -> {
97-
channel.sendResponse(new SearchShardsResponse(List.of(), List.of(), Collections.emptyMap()));
97+
var searchShardsResponse = new SearchShardsResponse(List.of(), List.of(), Collections.emptyMap());
98+
try {
99+
channel.sendResponse(searchShardsResponse);
100+
} finally {
101+
searchShardsResponse.decRef();
102+
}
98103
}
99104
);
100105
newService.registerRequestHandler(
@@ -130,7 +135,12 @@ private static MockTransportService startTransport(
130135
builder.add(node);
131136
}
132137
ClusterState build = ClusterState.builder(clusterName).nodes(builder.build()).build();
133-
channel.sendResponse(new ClusterStateResponse(clusterName, build, false));
138+
var clusterStateResponse = new ClusterStateResponse(clusterName, build, false);
139+
try {
140+
channel.sendResponse(clusterStateResponse);
141+
} finally {
142+
clusterStateResponse.decRef();
143+
}
134144
}
135145
);
136146
newService.start();

0 commit comments

Comments
 (0)