Refactor: rename dummy subclases

Author: prdoyle

libs/entitlement/qa/common/src/main/java/org/elasticsearch/entitlement/qa/common/DummyImplementations.java

@@ -9,6 +9,9 @@
 
 package org.elasticsearch.entitlement.qa.common;
 
+import java.net.InetAddress;
+import java.net.Socket;
+import java.security.cert.Certificate;
 import java.text.BreakIterator;
 import java.text.Collator;
 import java.text.DateFormat;
@@ -30,6 +33,9 @@
 import java.util.spi.LocaleServiceProvider;
 import java.util.spi.TimeZoneNameProvider;
 
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSocketFactory;
+
 /**
  * A collection of concrete subclasses that we can instantiate but that don't actually work.
  * <p>
@@ -248,6 +254,79 @@ public Locale[] getAvailableLocales() {
         }
     }
 
+    static class DummyHttpsURLConnection extends HttpsURLConnection {
+        DummyHttpsURLConnection() {
+            super(null);
+        }
+
+        @Override
+        public void connect() {
+            throw unexpected();
+        }
+
+        @Override
+        public void disconnect() {
+            throw unexpected();
+        }
+
+        @Override
+        public boolean usingProxy() {
+            throw unexpected();
+        }
+
+        @Override
+        public String getCipherSuite() {
+            throw unexpected();
+        }
+
+        @Override
+        public Certificate[] getLocalCertificates() {
+            throw unexpected();
+        }
+
+        @Override
+        public Certificate[] getServerCertificates() {
+            throw unexpected();
+        }
+    }
+
+    static class DummySSLSocketFactory extends SSLSocketFactory {
+        @Override
+        public Socket createSocket(String host, int port) {
+            throw unexpected();
+        }
+
+        @Override
+        public Socket createSocket(String host, int port, InetAddress localHost, int localPort) {
+            throw unexpected();
+        }
+
+        @Override
+        public Socket createSocket(InetAddress host, int port) {
+            throw unexpected();
+        }
+
+        @Override
+        public Socket createSocket(InetAddress address, int port, InetAddress localAddress, int localPort) {
+            throw unexpected();
+        }
+
+        @Override
+        public String[] getDefaultCipherSuites() {
+            throw unexpected();
+        }
+
+        @Override
+        public String[] getSupportedCipherSuites() {
+            throw unexpected();
+        }
+
+        @Override
+        public Socket createSocket(Socket s, String host, int port, boolean autoClose) {
+            throw unexpected();
+        }
+    }
+
     private static RuntimeException unexpected() {
         return new IllegalStateException("This method isn't supposed to be called");
     }

libs/entitlement/qa/common/src/main/java/org/elasticsearch/entitlement/qa/common/RestEntitlementsCheckAction.java

@@ -140,7 +140,7 @@ private static void setDefaultHostnameVerifier() {
     }
 
     private static void setDefaultSSLSocketFactory() {
-        HttpsURLConnection.setDefaultSSLSocketFactory(new TestSSLSocketFactory());
+        HttpsURLConnection.setDefaultSSLSocketFactory(new DummyImplementations.DummySSLSocketFactory());
     }
 
     @SuppressForbidden(reason = "Specifically testing Runtime.exit")
@@ -178,7 +178,7 @@ private static void processBuilder_startPipeline() {
     }
 
     private static void setHttpsConnectionProperties() {
-        new TestHttpsURLConnection().setSSLSocketFactory(new TestSSLSocketFactory());
+        new DummyImplementations.DummyHttpsURLConnection().setSSLSocketFactory(new DummyImplementations.DummySSLSocketFactory());
     }
 
     private static void system$$setIn() {