Skip to content

Commit 7f2d333

Browse files
authored
Larger offset when calculating the next histogram bucket to avoid col… (elastic#139675) (elastic#139737)
We generate legacy histograms in `DownsampleIT` and we used to small of a delta when generating the histogram values which caused them to collide. We ensure that the delta between the buckets is more than 1.0 fix that. Fixes elastic#139382 (cherry picked from commit 7ac049f) # Conflicts: # muted-tests.yml
1 parent 4090fb3 commit 7f2d333

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -400,9 +400,6 @@ tests:
400400
- class: org.elasticsearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT
401401
method: test {yaml=index/100_field_name_length_limit/Test field name length limit array synthetic source}
402402
issue: https://github.com/elastic/elasticsearch/issues/139300
403-
- class: org.elasticsearch.xpack.downsample.DownsampleIT
404-
method: testAggregateMethod
405-
issue: https://github.com/elastic/elasticsearch/issues/139382
406403
- class: org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorIT
407404
method: testCreatesChatCompletion_AndThenCreatesTextEmbedding
408405
issue: https://github.com/elastic/elasticsearch/issues/138012

x-pack/plugin/downsample/src/internalClusterTest/java/org/elasticsearch/xpack/downsample/DownsampleIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ private static double[] randomHistogramValues(int size) {
646646
final double[] array = new double[size];
647647
double minHistogramValue = randomDoubleBetween(0.0, 0.1, true);
648648
for (int i = 0; i < array.length; i++) {
649-
array[i] = minHistogramValue += randomDoubleBetween(0.0, 0.5, true);
649+
array[i] = minHistogramValue += randomDoubleBetween(0.1, 10.0, true);
650650
}
651651
return array;
652652
}

0 commit comments

Comments
 (0)