Skip to content

Commit 189e33e

Browse files
Fixed sorting for non editable requirement urls
1 parent 00e8510 commit 189e33e

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

pre_commit_hooks/requirements_txt_fixer.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ def __init__(self): # type: () -> None
2121
@property
2222
def name(self): # type: () -> bytes
2323
assert self.value is not None, self.value
24-
if self.value.startswith(b'-e '):
25-
return self.value.lower().partition(b'=')[-1]
24+
for egg in (b'#egg=', b'&egg='):
25+
if egg in self.value:
26+
return self.value.lower().partition(egg)[-1]
2627

2728
return self.value.lower().partition(b'==')[0]
2829

tests/requirements_txt_fixer_test.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@
4545
),
4646
(b'bar\npkg-resources==0.0.0\nfoo\n', FAIL, b'bar\nfoo\n'),
4747
(b'foo\npkg-resources==0.0.0\nbar\n', FAIL, b'bar\nfoo\n'),
48+
(
49+
b'git+ssh://git_url@tag#egg=ocflib\nDjango\nijk\n',
50+
FAIL,
51+
b'Django\nijk\ngit+ssh://git_url@tag#egg=ocflib\n',
52+
),
4853
),
4954
)
5055
def test_integration(input_s, expected_retval, output, tmpdir):

0 commit comments

Comments
 (0)