Skip to content

Commit b0d44c7

Browse files
committed
Ensure not to alter list in 'for' loop
1 parent 9e28aaf commit b0d44c7

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pre_commit_hooks/requirements_txt_fixer.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,10 @@ def fix_requirements(f):
7171

7272
# find and remove pkg-resources==0.0.0
7373
# which is automatically added by broken pip package under Debian
74-
for requirement in requirements:
75-
if requirement.value == b'pkg-resources==0.0.0\n':
76-
requirements.remove(requirement)
74+
requirements = [
75+
requirement for requirement in requirements
76+
if requirement.value != b'pkg-resources==0.0.0\n'
77+
]
7778

7879
for requirement in sorted(requirements):
7980
after.extend(requirement.comments)

0 commit comments

Comments
 (0)