Skip to content

Commit 31273aa

Browse files
committed
Add description field
1 parent 13a1bad commit 31273aa

File tree

4 files changed

+28
-20
lines changed

4 files changed

+28
-20
lines changed

pre_commit_mirror_maker/all/.pre-commit-hooks.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
- id: {id}
22
name: {name}
3+
description: {description!r}
34
entry: {entry}
45
language: {language}
56
'{match_key}': {match_val}

pre_commit_mirror_maker/main.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ def main(argv: Sequence[str] | None = None) -> int:
4141
'--package-name', required=True,
4242
help='Package name as it appears on the remote package manager.',
4343
)
44+
parser.add_argument(
45+
'--description', help='Hook description.', default='',
46+
)
4447

4548
mutex = parser.add_mutually_exclusive_group(required=True)
4649
mutex.add_argument(
@@ -88,6 +91,7 @@ def main(argv: Sequence[str] | None = None) -> int:
8891
make_repo(
8992
args.repo_path,
9093
name=args.package_name,
94+
description=args.description,
9195
language=args.language,
9296
entry=args.entry or args.package_name,
9397
id=args.id or args.entry or args.package_name,

tests/main_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ def test_main_passes_args(mock_make_repo):
4040
))
4141
mock_make_repo.assert_called_once_with(
4242
'.',
43-
language='ruby', name='scss-lint', entry='scss-lint-entry',
43+
language='ruby', name='scss-lint', description='',
44+
entry='scss-lint-entry',
4445
id='scss-lint-id', match_key='files', match_val=r'\.scss$', args='[]',
4546
require_serial='false', minimum_pre_commit_version='0',
4647
)

tests/make_repo_test.py

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ def in_git_dir(tmpdir):
6565
def test_commit_version(in_git_dir):
6666
_commit_version(
6767
'.',
68-
version='0.24.1', language='ruby', name='scss-lint', entry='scss-lint',
69-
id='scss-lint', match_key='files', match_val=r'\.scss$', args='[]',
70-
additional_dependencies='[]', require_serial='false',
71-
minimum_pre_commit_version='0',
68+
version='0.24.1', language='ruby', name='scss-lint', description='',
69+
entry='scss-lint', id='scss-lint', match_key='files',
70+
match_val=r'\.scss$', args='[]', additional_dependencies='[]',
71+
require_serial='false', minimum_pre_commit_version='0',
7272
)
7373

7474
# Assert that our things got copied over
@@ -86,15 +86,17 @@ def test_commit_version(in_git_dir):
8686
def test_arguments(in_git_dir):
8787
_commit_version(
8888
'.',
89-
version='0.6.2', language='python', name='yapf', entry='yapf',
90-
id='yapf', match_key='files', match_val=r'\.py$', args='["-i"]',
89+
version='0.6.2', language='python', name='yapf',
90+
description='Yet another Python formatter.', entry='yapf', id='yapf',
91+
match_key='files', match_val=r'\.py$', args='["-i"]',
9192
additional_dependencies='["scikit-learn"]', require_serial='false',
9293
minimum_pre_commit_version='0',
9394
)
9495
contents = in_git_dir.join('.pre-commit-hooks.yaml').read()
9596
assert yaml.safe_load(contents) == [{
9697
'id': 'yapf',
9798
'name': 'yapf',
99+
'description': 'Yet another Python formatter.',
98100
'entry': 'yapf',
99101
'language': 'python',
100102
'files': r'\.py$',
@@ -115,8 +117,8 @@ def fake_versions():
115117
def test_make_repo_starting_empty(in_git_dir, fake_versions):
116118
make_repo(
117119
'.',
118-
language='ruby', name='scss-lint', entry='scss-lint', id='scss-lint',
119-
match_key='files', match_val=r'\.scss$', args='[]',
120+
language='ruby', name='scss-lint', description='', entry='scss-lint',
121+
id='scss-lint', match_key='files', match_val=r'\.scss$', args='[]',
120122
require_serial='false', minimum_pre_commit_version='0',
121123
)
122124

@@ -147,8 +149,8 @@ def test_make_repo_starting_at_version(in_git_dir, fake_versions):
147149

148150
make_repo(
149151
'.',
150-
language='ruby', name='scss-lint', entry='scss-lint', id='scss-lint',
151-
match_key='files', match_val=r'\.scss$', args='[]',
152+
language='ruby', name='scss-lint', description='', entry='scss-lint',
153+
id='scss-lint', match_key='files', match_val=r'\.scss$', args='[]',
152154
require_serial='false', minimum_pre_commit_version='0',
153155
)
154156

@@ -167,8 +169,8 @@ def test_make_repo_starting_at_version(in_git_dir, fake_versions):
167169
def test_ruby_integration(in_git_dir):
168170
make_repo(
169171
'.',
170-
language='ruby', name='scss-lint', entry='scss-lint', id='scss-lint',
171-
match_key='files', match_val=r'\.scss$', args='[]',
172+
language='ruby', name='scss-lint', description='', entry='scss-lint',
173+
id='scss-lint', match_key='files', match_val=r'\.scss$', args='[]',
172174
require_serial='false', minimum_pre_commit_version='0',
173175
)
174176
# Our files should exist
@@ -187,8 +189,8 @@ def test_ruby_integration(in_git_dir):
187189
def test_node_integration(in_git_dir):
188190
make_repo(
189191
'.',
190-
language='node', name='jshint', entry='jshint', id='jshint',
191-
match_key='files', match_val=r'\.js$', args='[]',
192+
language='node', name='jshint', description='', entry='jshint',
193+
id='jshint', match_key='files', match_val=r'\.js$', args='[]',
192194
require_serial='false', minimum_pre_commit_version='0',
193195
)
194196
# Our files should exist
@@ -207,8 +209,8 @@ def test_node_integration(in_git_dir):
207209
def test_python_integration(in_git_dir):
208210
make_repo(
209211
'.',
210-
language='python', name='flake8', entry='flake8', id='flake8',
211-
match_key='files', match_val=r'\.py$', args='[]',
212+
language='python', name='flake8', description='', entry='flake8',
213+
id='flake8', match_key='files', match_val=r'\.py$', args='[]',
212214
require_serial='false', minimum_pre_commit_version='0',
213215
)
214216
# Our files should exist
@@ -230,9 +232,9 @@ def test_python_integration(in_git_dir):
230232
def test_rust_integration(in_git_dir):
231233
make_repo(
232234
'.',
233-
language='rust', name='shellharden', entry='shellharden',
234-
id='shellharden', match_key='types', match_val='shell',
235-
args='["--replace"]', require_serial='false',
235+
language='rust', name='shellharden', description='',
236+
entry='shellharden', id='shellharden', match_key='types',
237+
match_val='shell', args='["--replace"]', require_serial='false',
236238
minimum_pre_commit_version='0',
237239
)
238240
# Our files should exist

0 commit comments

Comments
 (0)