Merge pull request #355 from preactjs/test-flakyness

Reduce flakyness when clicking record

Author: marvinhagemeister

src/view/components/profiler/components/RenderReasons.tsx

@@ -80,8 +80,12 @@ export function RenderReasons() {
 							: "Capturing disabled. "}
 						<MessageBtn
 							onClick={() => {
-								store.profiler.setRenderReasonCapture(!captureReason);
+								const value = !captureReason;
+								store.profiler.setRenderReasonCapture(value);
 								store.profiler.isRecording.$ = true;
+								store.emit("start-profiling", {
+									captureRenderReasons: value,
+								});
 							}}
 							testId="toggle-render-reason"
 						>

src/view/components/profiler/components/TimelineBar/TimelineBar.tsx

@@ -47,6 +47,7 @@ export function TimelineBar() {
 
 	const onReset = useCallback(() => {
 		resetProfiler(store.profiler);
+		store.emit("stop-profiling", null);
 	}, [store]);
 
 	return (

src/view/components/stats/StatsPanel.tsx

@@ -61,6 +61,7 @@ export function StatsPanel() {
 	const onReset = useCallback(() => {
 		store.stats.data.$ = null;
 		store.stats.isRecording.$ = false;
+		store.emit("stop-profiling", null);
 	}, [store]);
 
 	return (

test-e2e/test-utils.ts

@@ -254,14 +254,19 @@ export async function clickRecordButton(page: Page) {
 	const selector = '[data-testid="record-btn"]';
 	await waitForSelector(page, selector);
 	const start = /Start/.test(await getAttribute(page, selector, "title"));
-	await clickSelector(page, selector);
-
-	await waitForAttribute(
-		page,
-		selector,
-		"title",
-		start ? /Stop Recording/ : /Start Recording/,
-	);
+	await clickSelector(page, selector, {
+		async retryUntil() {
+			await page.evaluate(
+				(s, start) => {
+					return (start ? /Stop Recording/ : /Start Recording/).test(
+						document.querySelector(s).title,
+					);
+				},
+				selector,
+				start,
+			);
+		},
+	});
 }
 
 // TODO: This might clash with windowing