Skip to content

Commit 844127d

Browse files
Distinct node name from HOC in DOM
1 parent 710ab60 commit 844127d

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

src/view/components/elements/TreeView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export function MarkResult(props: { text: string; id: ID }) {
169169
const start = idx > 0 ? text.slice(0, idx) : "";
170170
const end = idx < text.length ? text.slice(idx + m[0].length) : "";
171171
return (
172-
<span ref={ref}>
172+
<span ref={ref} data-testid="node-name">
173173
{start}
174174
<mark
175175
class={`${s.mark} ${isActive ? s.markSelected : ""}`}
@@ -181,7 +181,7 @@ export function MarkResult(props: { text: string; id: ID }) {
181181
</span>
182182
);
183183
}
184-
return <span>{text}</span>;
184+
return <span data-testid="node-name">{text}</span>;
185185
}
186186

187187
export function TreeItem(props: { key: any; id: ID; top: number }) {

src/view/components/profiler/flamegraph/modes/FlamegraphLayout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ export function FlamegraphLayout({
4747
const node = commit.nodes.get(pos.id)!;
4848
let text: any = "";
4949
if (pos.commitParent || pos.weight === -1) {
50-
text = node.name;
50+
text = <span data-testid="node-name">{node.name}</span>;
5151
} else {
5252
const self = formatTime(commit.selfDurations.get(node.id)!);
5353
const total = formatTime(node.endTime - node.startTime);
5454
text = (
5555
<>
56-
{node.name}
56+
<span data-testid="node-name">{node.name}</span>
5757
{filterHoc && node.hocs ? (
5858
<HocLabels hocs={node.hocs} nodeId={node.id} />
5959
) : (

src/view/components/profiler/flamegraph/ranked/RankedLayout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export function RankedLayout({
6868
);
6969
const text = (
7070
<>
71-
{node.name}
71+
<span data-testid="node-name">{node.name}</span>
7272
{hocs} ({formatTime(selfDuration)})
7373
</>
7474
);

test-e2e/tests/profiler/flamegraph/utils.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,9 @@ import { Page } from "puppeteer";
33
export async function getFlameNodes(page: Page) {
44
return await page.$$eval('[data-type="flamegraph"] > *', els => {
55
return els.map(el => {
6-
const text = el.textContent!;
76
return {
87
maximized: el.hasAttribute("data-maximized"),
9-
name: text.slice(
10-
0,
11-
text.includes("(") ? text.lastIndexOf("(") - 1 : text.length,
12-
),
8+
name: el.querySelector('[data-testid="node-name"]')!.textContent,
139
visible: el.hasAttribute("data-visible"),
1410
};
1511
});

0 commit comments

Comments
 (0)