Merge pull request #833 from preactjs/fix-ctrl-regression

marvinhagemeister · web-flow · commit a2dae646aa8a · 2021-09-02T17:37:39.000+02:00
Fix wrong state when browser handles click event
diff --git a/router.js b/router.js
@@ -7,7 +7,7 @@ const UPDATE = (state, url) => {
 	if (url && url.type === 'click') {
 		// ignore events the browser takes care of already:
 		if (url.ctrlKey || url.metaKey || url.altKey || url.shiftKey || url.button !== 0) {
-			return;
+			return state;
 		}
 
 		const link = url.target.closest('a[href]');

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ const UPDATE = (state, url) => {`
`7`	`7`	`if (url && url.type === 'click') {`
`8`	`8`	`// ignore events the browser takes care of already:`
`9`	`9`	`if (url.ctrlKey \|\| url.metaKey \|\| url.altKey \|\| url.shiftKey \|\| url.button !== 0) {`
`10`		`- return;`
	`10`	`+ return state;`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`const link = url.target.closest('a[href]');`