Always throw errors, not strings (#129)

sventschui · marvinhagemeister · commit 131ed173bcb3 · 2019-12-07T08:17:08.000+01:00
diff --git a/src/index.js b/src/index.js
@@ -201,7 +201,7 @@ function renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
 	}
 
 	s = `<${nodeName}${s}>`;
-	if (String(nodeName).match(/[\s\n\\/='"\0<>]/)) throw s;
+	if (String(nodeName).match(/[\s\n\\/='"\0<>]/)) throw new Error(`${nodeName} is not a valid HTML tag name in ${s}`);
 
 	let isVoid = String(nodeName).match(VOID_ELEMENTS);
 	if (isVoid) s = s.replace(/>$/, ' />');

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ function renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {`
`201`	`201`	`}`
`202`	`202`
`203`	`203`	s = `<${nodeName}${s}>`;
`204`		`- if (String(nodeName).match(/[\s\n\\/='"\0<>]/)) throw s;`
	`204`	+ if (String(nodeName).match(/[\s\n\\/='"\0<>]/)) throw new Error(`${nodeName} is not a valid HTML tag name in ${s}`);
`205`	`205`
`206`	`206`	`let isVoid = String(nodeName).match(VOID_ELEMENTS);`
`207`	`207`	`if (isVoid) s = s.replace(/>$/, ' />');`