Skip to content

Commit 40f3dd6

Browse files
committed
Omit defaultValue attribute
1 parent fdb033e commit 40f3dd6

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ function renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
163163

164164
if (name.match(/[\s\n\\/='"\0<>]/)) continue;
165165

166-
if (!(opts && opts.allAttributes) && (name==='key' || name==='ref' || name==='__self' || name==='__source')) continue;
166+
if (!(opts && opts.allAttributes) && (name==='key' || name==='ref' || name==='__self' || name==='__source' || name==='defaultValue')) continue;
167167

168168
if (name==='className') {
169169
if (props.class) continue;

test/render.js

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,41 @@ describe('render', () => {
5757
expect(render(<div foo={0} />)).to.equal(`<div foo="0"></div>`);
5858
});
5959

60+
it('should omit key attribute', () => {
61+
let rendered = render(<div key="test" />),
62+
expected = `<div></div>`;
63+
64+
expect(rendered).to.equal(expected);
65+
});
66+
67+
it('should omit ref attribute', () => {
68+
let rendered = render(<div ref="test" />),
69+
expected = `<div></div>`;
70+
71+
expect(rendered).to.equal(expected);
72+
});
73+
74+
it('should omit __source attribute', () => {
75+
let rendered = render(<div __source="test" />),
76+
expected = `<div></div>`;
77+
78+
expect(rendered).to.equal(expected);
79+
});
80+
81+
it('should omit __self attribute', () => {
82+
let rendered = render(<div __self="test" />),
83+
expected = `<div></div>`;
84+
85+
expect(rendered).to.equal(expected);
86+
});
87+
88+
it('should omit defaultValue attribute', () => {
89+
let rendered = render(<div defaultValue="test" />),
90+
expected = `<div></div>`;
91+
92+
expect(rendered).to.equal(expected);
93+
});
94+
6095
it('should include boolean aria-* attributes', () => {
6196
let rendered = render(<div aria-hidden aria-whatever={false} />),
6297
expected = `<div aria-hidden="true" aria-whatever="false"></div>`;

0 commit comments

Comments
 (0)