Empty VNodes should not render comments (to match preact no longer doing so)

developit · developit · commit 56b3859fc4f4 · 2016-11-29T14:06:59.000-05:00
diff --git a/src/index.js b/src/index.js
@@ -59,7 +59,7 @@ export default function renderToString(vnode, context, opts, inner) {
 		indentChar = typeof pretty==='string' ? pretty : '\t';
 
 	if (vnode==null) {
-		return '<!---->';
+		return '';
 	}
 
 	// #text nodes
diff --git a/test/jsx.js b/test/jsx.js
@@ -135,9 +135,7 @@ describe('jsx', () => {
 			<div>
 				<a></a>
 				<b></b>
-				<c>
-					<!---->
-				</c>
+				<c></c>
 			</div>
 		`);
 	});

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export default function renderToString(vnode, context, opts, inner) {`
`59`	`59`	`indentChar = typeof pretty==='string' ? pretty : '\t';`
`60`	`60`
`61`	`61`	`if (vnode==null) {`
`62`		`- return '<!---->';`
	`62`	`+ return '';`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`// #text nodes`
-Original file line number
+Diff line change
 			<div>
 				<a></a>
 				<b></b>
 -				<c>
 -					<!---->
 -				</c>
 +				<c></c>
 			</div>
 		`);
 	});