Skip to content

Commit b6f6fc7

Browse files
Merge pull request #186 from preactjs/empty-css-value
Fix empty CSS value not ignored in inline styles
2 parents 9a5e748 + 2d33ea7 commit b6f6fc7

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export function styleObjToCss(s) {
5151
let str = '';
5252
for (let prop in s) {
5353
let val = s[prop];
54-
if (val != null) {
54+
if (val != null && val !== '') {
5555
if (str) str += ' ';
5656
// str += jsToCss(prop);
5757
str +=

test/render.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,13 @@ describe('render', () => {
258258
expect(rendered).to.equal(expected);
259259
});
260260

261+
it('should ignore empty css value', () => {
262+
let rendered = render(<div style={{ color: '' }} />);
263+
let expected = `<div></div>`;
264+
265+
expect(rendered).to.equal(expected);
266+
});
267+
261268
it('should render SVG elements', () => {
262269
let rendered = render(
263270
<svg>

0 commit comments

Comments
 (0)