Skip to content

Commit c296a79

Browse files
authored
Fix: serialize defaultValue as value attribute (#203)
* Fix: serialize defaultValue as value attribute h/t @washingtonsteven who found this * Update tests for defaultValue --> value
1 parent c9bd4bb commit c296a79

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/index.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,12 +240,13 @@ function _renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
240240
(name === 'key' ||
241241
name === 'ref' ||
242242
name === '__self' ||
243-
name === '__source' ||
244-
name === 'defaultValue')
243+
name === '__source')
245244
)
246245
continue;
247246

248-
if (name === 'className') {
247+
if (name === 'defaultValue') {
248+
name = 'value';
249+
} else if (name === 'className') {
249250
if (props.class) continue;
250251
name = 'class';
251252
} else if (isSvgMode && name.match(/^xlink:?./)) {

test/render.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ describe('render', () => {
8282
expect(rendered).to.equal(expected);
8383
});
8484

85-
it('should omit defaultValue attribute', () => {
85+
it('should serialize defaultValue props to the value attribute', () => {
8686
let rendered = render(<div defaultValue="test" />),
87-
expected = `<div></div>`;
87+
expected = `<div value="test"></div>`;
8888

8989
expect(rendered).to.equal(expected);
9090
});

0 commit comments

Comments
 (0)