Merge pull request #158 from preactjs/bugfix/aria-boolean-values

Stringify boolean aria-* attributes

Author: marvinhagemeister

src/index.js

@@ -176,6 +176,12 @@ function renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
 				v = styleObjToCss(v);
 			}
 
+			// always use string values instead of booleans for aria attributes
+			// also see https://github.com/preactjs/preact/pull/2347/files
+			if (name[0] === 'a' && name['1'] === 'r' && typeof v === 'boolean') {
+				v = String(v);
+			}
+
 			let hooked = opts.attributeHook && opts.attributeHook(name, v, context, opts, isComponent);
 			if (hooked || hooked==='') {
 				s += hooked;

test/render.js

@@ -57,6 +57,13 @@ describe('render', () => {
 			expect(render(<div foo={0} />)).to.equal(`<div foo="0"></div>`);
 		});
 
+		it('should include boolean aria-* attributes', () => {
+			let rendered = render(<div aria-hidden aria-whatever={false} />),
+				expected = `<div aria-hidden="true" aria-whatever="false"></div>`;
+
+			expect(rendered).to.equal(expected);
+		});
+
 		describe('attribute name sanitization', () => {
 			it('should omit attributes with invalid names', () => {
 				let rendered = render(h('div', {