Skip to content

Commit 094c33b

Browse files
rschristianJoviDeCroock
authored andcommitted
refactor: Skip dom check for inferring lower-cased event names (#4720)
1 parent 3e4db38 commit 094c33b

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

src/create-element.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,6 @@ export function createElement(type, props, children) {
2929
arguments.length > 3 ? slice.call(arguments, 2) : children;
3030
}
3131

32-
<<<<<<< HEAD
33-
// If a Component VNode, check for and apply defaultProps
34-
// Note: type may be undefined in development, must never error here.
35-
if (typeof type == 'function' && type.defaultProps != NULL) {
36-
for (i in type.defaultProps) {
37-
if (normalizedProps[i] === UNDEFINED) {
38-
normalizedProps[i] = type.defaultProps[i];
39-
}
40-
}
41-
}
42-
43-
=======
44-
>>>>>>> 04457d6e (Move `defaultProps` into `preact/compat` (#4657))
4532
return createVNode(type, normalizedProps, key, ref, NULL);
4633
}
4734

src/diff/props.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,9 @@ export function setProperty(dom, name, value, oldValue, namespace) {
6565
// Benchmark for comparison: https://esbench.com/bench/574c954bdb965b9a00965ac6
6666
else if (name[0] == 'o' && name[1] == 'n') {
6767
useCapture = name != (name = name.replace(CAPTURE_REGEX, '$1'));
68-
const lowerCaseName = name.toLowerCase();
6968

7069
// Infer correct casing for DOM built-in events:
71-
if (lowerCaseName in dom || name == 'onFocusOut' || name == 'onFocusIn')
72-
name = lowerCaseName.slice(2);
70+
if (name[2].toLowerCase() != name[2]) name = name.toLowerCase().slice(2);
7371
else name = name.slice(2);
7472

7573
if (!dom._listeners) dom._listeners = {};

test/browser/events.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ describe('event handling', () => {
5858
expect(
5959
proto.addEventListener
6060
).to.have.been.calledOnce.and.to.have.been.calledWithExactly(
61-
'OtherClick',
61+
'otherclick',
6262
sinon.match.func,
6363
false
6464
);

0 commit comments

Comments
 (0)