Skip to content

Commit 0a3c7b4

Browse files
authored
chore: remove sinon (#4820)
Now that we've switched entirely to vitest's spies, we can drop the following: - `sinon` (since we use `vi.fn` and `vi.spyOn`) - `chai` (since vitest pulls chai in itself) - `sinon-chai` (since we use vitest's own assertions now) - associated types packages
1 parent 319d304 commit 0a3c7b4

File tree

7 files changed

+37
-180
lines changed

7 files changed

+37
-180
lines changed

devtools/test/browser/addHookName.test.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { createElement, render, options } from 'preact';
22
import { setupScratch, teardown } from '../../../test/_util/helpers';
33
import { useState } from 'preact/hooks';
44
import { addHookName } from 'preact/devtools';
5+
import { vi } from 'vitest';
56

67
/** @jsx createElement */
78

@@ -32,7 +33,7 @@ describe('addHookName', () => {
3233
});
3334

3435
it('should call options hook with value', () => {
35-
let spy = (options._addHookName = sinon.spy());
36+
let spy = (options._addHookName = vi.fn());
3637

3738
function useFoo() {
3839
return addHookName(useState(0), 'foo');
@@ -45,7 +46,7 @@ describe('addHookName', () => {
4546

4647
render(<App />, scratch);
4748

48-
expect(spy).to.be.calledOnce;
49-
expect(spy).to.be.calledWith('foo');
49+
expect(spy).toHaveBeenCalledOnce();
50+
expect(spy).toHaveBeenCalledWith('foo');
5051
});
5152
});

jsx-runtime/test/browser/jsx-runtime.test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
} from 'preact/jsx-runtime';
1111
import { setupScratch, teardown } from '../../../test/_util/helpers';
1212
import { encodeEntities } from '../../src/utils';
13+
import { vi } from 'vitest';
1314

1415
function createSignal(value) {
1516
return {
@@ -97,9 +98,9 @@ describe('Babel jsx/jsxDEV', () => {
9798
});
9899

99100
it('should call options.vnode with the vnode', () => {
100-
options.vnode = sinon.spy();
101+
options.vnode = vi.fn();
101102
const vnode = jsx('div', { class: 'foo' }, 'key');
102-
expect(options.vnode).to.have.been.calledWith(vnode);
103+
expect(options.vnode).toHaveBeenCalledWith(vnode);
103104
});
104105
});
105106

package-lock.json

Lines changed: 3 additions & 140 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,13 +207,10 @@
207207
"@babel/preset-env": "^7.26.0",
208208
"@babel/register": "^7.25.9",
209209
"@biomejs/biome": "^1.9.4",
210-
"@types/chai": "^5.0.1",
211210
"@types/node": "^18.19.87",
212-
"@types/sinon": "^17.0.3",
213211
"@vitest/browser": "^3.2.1",
214212
"@vitest/coverage-v8": "^3.2.4",
215213
"babel-plugin-transform-rename-properties": "0.1.0",
216-
"chai": "^5.2.0",
217214
"coveralls": "^3.1.1",
218215
"cross-env": "^7.0.3",
219216
"errorstacks": "^2.4.1",
@@ -227,8 +224,6 @@
227224
"preact-render-to-string": "^6.5.0",
228225
"prop-types": "^15.8.1",
229226
"sade": "^1.8.1",
230-
"sinon": "^19.0.2",
231-
"sinon-chai": "^4.0.0",
232227
"terser": "5.16.0",
233228
"typescript": "5.1.6",
234229
"undici": "^4.12.0",

0 commit comments

Comments
 (0)