Remove contains with a simple parentNode check (#4666)

JoviDeCroock · JoviDeCroock · commit 63e552561bbe · 2025-05-30T10:42:33.000+02:00
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -358,7 +358,7 @@ function insert(parentVNode, oldDom, parentDom) {
 
 		return oldDom;
 	} else if (parentVNode._dom != oldDom) {
-		if (oldDom && parentVNode.type && !parentDom.contains(oldDom)) {
+		if (oldDom && parentVNode.type && !oldDom.parentNode) {
 			oldDom = getDomSibling(parentVNode);
 		}
 		parentDom.insertBefore(parentVNode._dom, oldDom || NULL);
diff --git a/src/index-5.d.ts b/src/index-5.d.ts
@@ -290,7 +290,6 @@ interface ContainerNode {
 	readonly firstChild: ContainerNode | null;
 	readonly childNodes: ArrayLike<ContainerNode>;
 
-	contains(other: ContainerNode | null): boolean;
 	insertBefore(node: ContainerNode, child: ContainerNode | null): ContainerNode;
 	appendChild(node: ContainerNode): ContainerNode;
 	removeChild(child: ContainerNode): ContainerNode;
diff --git a/src/index.d.ts b/src/index.d.ts
@@ -289,7 +289,6 @@ interface ContainerNode {
 	readonly firstChild: ContainerNode | null;
 	readonly childNodes: ArrayLike<ContainerNode>;
 
-	contains(other: ContainerNode | null): boolean;
 	insertBefore(node: ContainerNode, child: ContainerNode | null): ContainerNode;
 	appendChild(node: ContainerNode): ContainerNode;
 	removeChild(child: ContainerNode): ContainerNode;

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ function insert(parentVNode, oldDom, parentDom) {`
`358`	`358`
`359`	`359`	`return oldDom;`
`360`	`360`	`} else if (parentVNode._dom != oldDom) {`
`361`		`- if (oldDom && parentVNode.type && !parentDom.contains(oldDom)) {`
	`361`	`+ if (oldDom && parentVNode.type && !oldDom.parentNode) {`
`362`	`362`	`oldDom = getDomSibling(parentVNode);`
`363`	`363`	`}`
`364`	`364`	`parentDom.insertBefore(parentVNode._dom, oldDom \|\| NULL);`