Skip to content

Commit 9e8d885

Browse files
committed
clarify naming in the Render Queue
1 parent 98cb876 commit 9e8d885

File tree

2 files changed

+21
-16
lines changed

2 files changed

+21
-16
lines changed

src/component.js

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -91,21 +91,25 @@ Component.prototype.render = Fragment;
9191
/**
9292
* @param {import('./internal').Internal} internal The internal to rerender
9393
*/
94-
function rerender(internal) {
95-
if (~internal.flags & MODE_UNMOUNTING && internal.flags & DIRTY_BIT) {
96-
const vnode = createElement(internal.type, internal.props);
97-
vnode.props = internal.props;
94+
function renderQueuedInternal(internal) {
95+
// Don't render unmounting/unmounted trees:
96+
if (internal.flags & MODE_UNMOUNTING) return;
9897

99-
patch(internal, vnode, getParentDom(internal));
100-
commitRoot(internal);
101-
}
98+
// Don't render trees already rendered in this pass:
99+
if (!(internal.flags & DIRTY_BIT)) return;
100+
101+
const vnode = createElement(internal.type, internal.props);
102+
vnode.props = internal.props;
103+
104+
patch(internal, vnode, getParentDom(internal));
105+
commitRoot(internal);
102106
}
103107

104108
/**
105109
* The render queue
106110
* @type {Array<import('./internal').Internal>}
107111
*/
108-
let rerenderQueue = [];
112+
let renderQueue = [];
109113

110114
/*
111115
* The value of `Component.debounce` must asynchronously invoke the passed in callback. It is
@@ -126,22 +130,22 @@ export function enqueueRender(internal) {
126130
if (
127131
(!(internal.flags & DIRTY_BIT) &&
128132
(internal.flags |= DIRTY_BIT) &&
129-
rerenderQueue.push(internal) &&
130-
!process._rerenderCount++) ||
133+
renderQueue.push(internal) &&
134+
!processRenderQueue._rerenderCount++) ||
131135
prevDebounce !== options.debounceRendering
132136
) {
133137
prevDebounce = options.debounceRendering;
134-
(prevDebounce || setTimeout)(process);
138+
(prevDebounce || setTimeout)(processRenderQueue);
135139
}
136140
}
137141

138142
/** Flush the render queue by rerendering all queued components */
139-
function process() {
140-
while ((len = process._rerenderCount = rerenderQueue.length)) {
141-
rerenderQueue.sort((a, b) => a._depth - b._depth);
143+
function processRenderQueue() {
144+
while ((len = processRenderQueue._rerenderCount = renderQueue.length)) {
145+
renderQueue.sort((a, b) => a._depth - b._depth);
142146
while (len--) {
143-
rerender(rerenderQueue.shift());
147+
renderQueuedInternal(renderQueue.shift());
144148
}
145149
}
146150
}
147-
let len = (process._rerenderCount = 0);
151+
let len = (processRenderQueue._rerenderCount = 0);

src/create-context.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ let nextContextId = 0;
44

55
const providers = new Set();
66

7+
/** @param {import('./internal').Internal} internal */
78
export const unsubscribeFromContext = internal => {
89
// if this was a context provider, delete() returns true and we exit:
910
if (providers.delete(internal)) return;

0 commit comments

Comments
 (0)