Leverage Object.assign

Author: JoviDeCroock

compat/src/util.js

@@ -1,14 +1,4 @@
-/**
- * Assign properties from `props` to `obj`
- * @template O, P The obj and props types
- * @param {O} obj The object to copy properties to
- * @param {P} props The object to copy properties from
- * @returns {O & P}
- */
-export function assign(obj, props) {
-	for (let i in props) obj[i] = props[i];
-	return /** @type {O & P} */ (obj);
-}
+export const assign = Object.assign;
 
 /**
  * Check if two objects have a different shape
@@ -29,5 +19,6 @@ export function shallowDiffers(a, b) {
  * @returns {boolean}
  */
 export function is(x, y) {
+	// TODO: can we replace this with Object.is?
 	return (x === y && (x !== 0 || 1 / x === 1 / y)) || (x !== x && y !== y);
 }

debug/src/util.js

@@ -1,14 +1,4 @@
-/**
- * Assign properties from `props` to `obj`
- * @template O, P The obj and props types
- * @param {O} obj The object to copy properties to
- * @param {P} props The object to copy properties from
- * @returns {O & P}
- */
-export function assign(obj, props) {
-	for (let i in props) obj[i] = props[i];
-	return /** @type {O & P} */ (obj);
-}
+export const assign = Object.assign;
 
 export function isNaN(value) {
 	return value !== value;

src/diff/index.js

@@ -233,7 +233,7 @@ export function diff(
 			c.state = c._nextState;
 
 			if (c.getChildContext != null) {
-				globalContext = assign(assign({}, globalContext), c.getChildContext());
+				globalContext = assign({}, globalContext, c.getChildContext());
 			}
 
 			if (isClassComponent && !isNew && c.getSnapshotBeforeUpdate != null) {

src/util.js

@@ -1,19 +1,8 @@
 import { EMPTY_ARR } from './constants';
 
 export const isArray = Array.isArray;
-
-/**
- * Assign properties from `props` to `obj`
- * @template O, P The obj and props types
- * @param {O} obj The object to copy properties to
- * @param {P} props The object to copy properties from
- * @returns {O & P}
- */
-export function assign(obj, props) {
-	// @ts-expect-error We change the type of `obj` to be `O & P`
-	for (let i in props) obj[i] = props[i];
-	return /** @type {O & P} */ (obj);
-}
+export const assign = Object.assign;
+export const slice = EMPTY_ARR.slice;
 
 /**
  * Remove a child node from its parent if attached. This is a workaround for
@@ -24,5 +13,3 @@ export function assign(obj, props) {
 export function removeNode(node) {
 	if (node && node.parentNode) node.parentNode.removeChild(node);
 }
-
-export const slice = EMPTY_ARR.slice;