Remove contains with a simple parentNode check (#4666)

JoviDeCroock · JoviDeCroock · commit b046f52acb14 · 2025-02-18T07:23:42.000+01:00
diff --git a/compat/src/portals.js b/compat/src/portals.js
@@ -39,7 +39,6 @@ function Portal(props) {
 			nodeType: 1,
 			parentNode: container,
 			childNodes: [],
-			contains: () => true,
 			// Technically this isn't needed
 			appendChild(child) {
 				this.childNodes.push(child);
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -340,7 +340,7 @@ function insert(parentVNode, oldDom, parentDom) {
 
 		return oldDom;
 	} else if (parentVNode._dom != oldDom) {
-		if (oldDom && parentVNode.type && !parentDom.contains(oldDom)) {
+		if (oldDom && parentVNode.type && !oldDom.parentNode) {
 			oldDom = getDomSibling(parentVNode);
 		}
 		parentDom.insertBefore(parentVNode._dom, oldDom || NULL);
diff --git a/src/index-5.d.ts b/src/index-5.d.ts
@@ -290,7 +290,6 @@ interface ContainerNode {
 	readonly firstChild: ContainerNode | null;
 	readonly childNodes: ArrayLike<ContainerNode>;
 
-	contains(other: ContainerNode | null): boolean;
 	insertBefore(node: ContainerNode, child: ContainerNode | null): ContainerNode;
 	appendChild(node: ContainerNode): ContainerNode;
 	removeChild(child: ContainerNode): ContainerNode;
diff --git a/src/index.d.ts b/src/index.d.ts
@@ -289,7 +289,6 @@ interface ContainerNode {
 	readonly firstChild: ContainerNode | null;
 	readonly childNodes: ArrayLike<ContainerNode>;
 
-	contains(other: ContainerNode | null): boolean;
 	insertBefore(node: ContainerNode, child: ContainerNode | null): ContainerNode;
 	appendChild(node: ContainerNode): ContainerNode;
 	removeChild(child: ContainerNode): ContainerNode;

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ function insert(parentVNode, oldDom, parentDom) {`
`340`	`340`
`341`	`341`	`return oldDom;`
`342`	`342`	`} else if (parentVNode._dom != oldDom) {`
`343`		`- if (oldDom && parentVNode.type && !parentDom.contains(oldDom)) {`
	`343`	`+ if (oldDom && parentVNode.type && !oldDom.parentNode) {`
`344`	`344`	`oldDom = getDomSibling(parentVNode);`
`345`	`345`	`}`
`346`	`346`	`parentDom.insertBefore(parentVNode._dom, oldDom \|\| NULL);`