Remove replaceNode

Author: JoviDeCroock

src/internal.d.ts

@@ -95,6 +95,7 @@ export interface PreactElement extends preact.ContainerNode {
 	data?: CharacterData['data'];
 	// Property to set __dangerouslySetInnerHTML
 	innerHTML?: Element['innerHTML'];
+	remove?: Element['remove'];
 
 	// Attribute reading and setting
 	readonly attributes?: Element['attributes'];
@@ -110,6 +111,8 @@ export interface PreactElement extends preact.ContainerNode {
 
 	// nextSibling required for inserting nodes
 	readonly nextSibling: ContainerNode | null;
+	readonly firstChild: ContainerNode | null;
+
 
 	// Used to match DOM nodes to VNodes during hydration. Note: doesn't exist
 	// on Text nodes
@@ -162,7 +165,6 @@ export interface Component<P = {}, S = {}> extends preact.Component<P, S> {
 	// When component is functional component, this is reset to functional component
 	constructor: ComponentType<P>;
 	state: S; // Override Component["state"] to not be readonly for internal use, specifically Hooks
-	base?: PreactElement;
 
 	_dirty: boolean;
 	_force?: boolean;

src/render.js

@@ -22,19 +22,16 @@ export function render(vnode, parentDom, replaceNode) {
 	// We abuse the `replaceNode` parameter in `hydrate()` to signal if we are in
 	// hydration mode or not by passing the `hydrate` function instead of a DOM
 	// element..
-	let isHydrating = typeof replaceNode == 'function';
+	let isHydrating = replaceNode === hydrate;
 
 	// To be able to support calling `render()` multiple times on the same
 	// DOM node, we need to obtain a reference to the previous tree. We do
 	// this by assigning a new `_children` property to DOM nodes which points
 	// to the last rendered tree. By default this property is not present, which
 	// means that we are mounting a new tree for the first time.
-	let oldVNode = isHydrating
-		? null
-		: (replaceNode && replaceNode._children) || parentDom._children;
+	let oldVNode = isHydrating ? null : parentDom._children;
 
-	vnode = ((!isHydrating && replaceNode) || parentDom)._children =
-		createElement(Fragment, null, [vnode]);
+	vnode = parentDom._children = createElement(Fragment, null, [vnode]);
 
 	// List of effects that need to be called after diffing.
 	let commitQueue = [],
@@ -47,19 +44,13 @@ export function render(vnode, parentDom, replaceNode) {
 		oldVNode || EMPTY_OBJ,
 		EMPTY_OBJ,
 		parentDom.namespaceURI,
-		!isHydrating && replaceNode
-			? [replaceNode]
-			: oldVNode
-				? null
-				: parentDom.firstChild
-					? slice.call(parentDom.childNodes)
-					: null,
+		oldVNode
+			? null
+			: parentDom.firstChild
+				? slice.call(parentDom.childNodes)
+				: null,
 		commitQueue,
-		!isHydrating && replaceNode
-			? replaceNode
-			: oldVNode
-				? oldVNode._dom
-				: parentDom.firstChild,
+		oldVNode ? oldVNode._dom : parentDom.firstChild,
 		isHydrating,
 		refQueue
 	);

test/browser/replaceNode.test.js

@@ -0,0 +1,18 @@
+# Breaking changes
+
+- The package now only exports ESM https://github.com/graphql/graphql-js/pull/3552
+- `GraphQLError` can now only be constructed with a message and options rather than also with positional arguments https://github.com/graphql/graphql-js/pull/3577
+- `createSourceEventStream` can now only be used with with an object-argument rather than alsow with positional arguments https://github.com/graphql/graphql-js/pull/3635
+- Allow `subscribe` to return a value rather than only a Promise, this makes the returned type in line with `execute` https://github.com/graphql/graphql-js/pull/3620
+- `execute` throws an error when it sees a `@defer` or `@stream` directive, use `experimentalExecuteIncrementally` instead https://github.com/graphql/graphql-js/pull/3722
+- Remove support for defer/stream from subscriptions, in case you have fragments that you use with `defer/stream` that end up in a subscription, use the `if` argument of the directive to disable it in your subscriptin operations https://github.com/graphql/graphql-js/pull/3742
+
+## Removals
+
+- Remove `graphql/subscription` module https://github.com/graphql/graphql-js/pull/3570
+- Remove `getOperationType` function https://github.com/graphql/graphql-js/pull/3571
+- Remove `getVisitFn` function https://github.com/graphql/graphql-js/pull/3580
+- Remove `printError` and `formatError` utils https://github.com/graphql/graphql-js/pull/3582
+- Remove `assertValidName` and `isValidNameError` utils https://github.com/graphql/graphql-js/pull/3572
+- Remove `assertValidExecutionArguments` function https://github.com/graphql/graphql-js/pull/3643
+- Remove `TokenKindEnum`, `KindEnum` and `DirectiveLocationEnum` types, use `Kind`, `TokenKind` and `DirectiveLocation` instead. https://github.com/graphql/graphql-js/pull/3579