Skip to content

Commit e34cec7

Browse files
committed
Remove select IE11 fix
1 parent 1741ea4 commit e34cec7

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

TODO.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
- https://github.com/preactjs/preact/pull/4362
2+
- https://github.com/preactjs/preact/pull/4358
3+
- https://github.com/preactjs/preact/pull/4361
4+
- https://github.com/preactjs/preact/pull/4460

src/diff/index.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -540,12 +540,7 @@ function diffElementNodes(
540540
// despite the attribute not being present. When the attribute
541541
// is missing the progress bar is treated as indeterminate.
542542
// To fix that we'll always update it when it is 0 for progress elements
543-
(inputValue !== dom[i] ||
544-
(nodeType === 'progress' && !inputValue) ||
545-
// This is only for IE 11 to fix <select> value not being updated.
546-
// To avoid a stale select value we need to set the option.value
547-
// again, which triggers IE11 to re-evaluate the select value
548-
(nodeType === 'option' && inputValue !== oldProps[i]))
543+
(inputValue !== dom[i] || (nodeType === 'progress' && !inputValue))
549544
) {
550545
setProperty(dom, i, inputValue, oldProps[i], namespace);
551546
}

0 commit comments

Comments
 (0)