Preserve event handler return values (#3812)

developit · andrewiggins · andrewiggins · commit eccd0f9ce61d · 2022-12-04T12:00:37.000-08:00
I'm not aware of any bugs caused by this, but currently we drop the return value of event handlers rather than returning it to the DOM. This corrects that.

Co-authored-by: Andre Wiggins &lt;459878+andrewiggins@users.noreply.github.com&gt;
diff --git a/src/diff/props.js b/src/diff/props.js
@@ -108,9 +108,9 @@ export function setProperty(dom, name, value, oldValue, isSvg) {
  * @private
  */
 function eventProxy(e) {
-	this._listeners[e.type + false](options.event ? options.event(e) : e);
+	return this._listeners[e.type + false](options.event ? options.event(e) : e);
 }
 
 function eventProxyCapture(e) {
-	this._listeners[e.type + true](options.event ? options.event(e) : e);
+	return this._listeners[e.type + true](options.event ? options.event(e) : e);
 }

Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,9 @@ export function setProperty(dom, name, value, oldValue, isSvg) {`
`108`	`108`	`* @private`
`109`	`109`	`*/`
`110`	`110`	`function eventProxy(e) {`
`111`		`- this._listeners[e.type + false](options.event ? options.event(e) : e);`
	`111`	`+ return this._listeners[e.type + false](options.event ? options.event(e) : e);`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`function eventProxyCapture(e) {`
`115`		`- this._listeners[e.type + true](options.event ? options.event(e) : e);`
	`115`	`+ return this._listeners[e.type + true](options.event ? options.event(e) : e);`
`116`	`116`	`}`