Remove component.base

Author: JoviDeCroock

TODO.md

@@ -4,6 +4,7 @@
 - https://github.com/preactjs/preact/pull/4460
 - https://github.com/preactjs/preact/pull/4453
 - Backing VNodes
+- Remove deprecated lifecycle methods
 - Try to get rid of DOM pointers
 - Separate mount/update paths
 - Rethink TypeScript types

compat/src/index.js

@@ -116,7 +116,8 @@ function unmountComponentAtNode(container) {
 function findDOMNode(component) {
 	return (
 		(component &&
-			(component.base || (component.nodeType === 1 && component))) ||
+			((component._vnode && component._vnode._dom) ||
+				(component.nodeType === 1 && component))) ||
 		null
 	);
 }

src/component.js

@@ -159,11 +159,11 @@ function renderComponent(component) {
  */
 function updateParentDomPointers(vnode) {
 	if ((vnode = vnode._parent) != null && vnode._component != null) {
-		vnode._dom = vnode._component.base = null;
+		vnode._dom = null;
 		for (let i = 0; i < vnode._children.length; i++) {
 			let child = vnode._children[i];
 			if (child != null && child._dom != null) {
-				vnode._dom = vnode._component.base = child._dom;
+				vnode._dom = child._dom;
 				break;
 			}
 		}

src/diff/index.js

@@ -258,8 +258,6 @@ export function diff(
 				refQueue
 			);
 
-			c.base = newVNode._dom;
-
 			// We successfully rendered this VNode, unset any stored hydration/bailout state:
 			newVNode._flags &= RESET_MODE;
 
@@ -608,7 +606,7 @@ export function unmount(vnode, parentVNode, skipRemove) {
 			}
 		}
 
-		r.base = r._parentDom = null;
+		r._parentDom = null;
 	}
 
 	if ((r = vnode._children)) {

src/index.d.ts

@@ -159,7 +159,6 @@ export abstract class Component<P, S> {
 	state: Readonly<S>;
 	props: RenderableProps<P>;
 	context: any;
-	base?: Element | Text;
 
 	// From https://github.com/DefinitelyTyped/DefinitelyTyped/blob/e836acc75a78cf0655b5dfdbe81d69fdd4d8a252/types/react/index.d.ts#L402
 	// // We MUST keep setState() as a unified signature because it allows proper checking of the method return type.

src/internal.d.ts

@@ -167,7 +167,6 @@ declare global {
 		// When component is functional component, this is reset to functional component
 		constructor: ComponentType<P>;
 		state: S; // Override Component["state"] to not be readonly for internal use, specifically Hooks
-		base?: PreactElement;
 
 		_dirty: boolean;
 		_force?: boolean;