From a1745f63aef62e7685e42e8fca5d2b112b3dabe2 Mon Sep 17 00:00:00 2001 From: jdecroock Date: Thu, 13 Feb 2025 14:28:48 +0100 Subject: [PATCH 1/2] Revert "Adds support for react 19 (#4623)" This reverts commit a1ff5f32e8a1a9e73e9da70abfe85a7a80b282fd. --- compat/package.json | 4 ---- compat/react-19.js | 12 ------------ compat/react-19.mjs | 12 ------------ package.json | 7 ------- 4 files changed, 35 deletions(-) delete mode 100644 compat/react-19.js delete mode 100644 compat/react-19.mjs diff --git a/compat/package.json b/compat/package.json index 352e754634..bb80a0fa7a 100644 --- a/compat/package.json +++ b/compat/package.json @@ -34,10 +34,6 @@ "import": "./server.mjs", "require": "./server.js" }, - "./react-19": { - "import": "./react-19.mjs", - "require": "./react-19.js" - }, "./jsx-runtime": { "import": "./jsx-runtime.mjs", "require": "./jsx-runtime.js" diff --git a/compat/react-19.js b/compat/react-19.js deleted file mode 100644 index f640085413..0000000000 --- a/compat/react-19.js +++ /dev/null @@ -1,12 +0,0 @@ -require('preact/compat'); - -const { options } = require('preact'); - -const oldVNode = options.vnode; -options.vnode = vnode => { - if (typeof vnode.type === 'function') { - vnode.type._forwarded = true; - } - - if (oldVNode) oldVNode(vnode); -}; diff --git a/compat/react-19.mjs b/compat/react-19.mjs deleted file mode 100644 index f88e011e35..0000000000 --- a/compat/react-19.mjs +++ /dev/null @@ -1,12 +0,0 @@ -import 'preact/compat'; - -import { options } from 'preact'; - -const oldVNode = options.vnode; -options.vnode = vnode => { - if (typeof vnode.type === 'function') { - vnode.type._forwarded = true; - } - - if (oldVNode) oldVNode(vnode); -}; diff --git a/package.json b/package.json index 3ea0361556..f92ca82cdd 100644 --- a/package.json +++ b/package.json @@ -89,11 +89,6 @@ "import": "./compat/jsx-runtime.mjs", "require": "./compat/jsx-runtime.js" }, - "./compat/react-19": { - "types": "./compat/src/index.d.ts", - "import": "./compat/react-19.mjs", - "require": "./compat/react-19.js" - }, "./compat/jsx-dev-runtime": { "types": "./jsx-runtime/src/index.d.ts", "import": "./compat/jsx-dev-runtime.mjs", @@ -171,8 +166,6 @@ "compat/test-utils.js", "compat/jsx-runtime.js", "compat/jsx-runtime.mjs", - "compat/react-19.js", - "compat/react-19.mjs", "compat/jsx-dev-runtime.js", "compat/jsx-dev-runtime.mjs", "compat/package.json", From 93d9d766ba7fb528dca03d4976e2ec1a79b881c5 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Thu, 13 Feb 2025 17:09:49 +0100 Subject: [PATCH 2/2] Update build-test.yml --- .github/workflows/build-test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 98604af796..a94951cce8 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -43,6 +43,7 @@ jobs: timeout-minutes: 2 with: github-token: ${{ secrets.GITHUB_TOKEN }} + fail-on-error: false - name: Package # Use --ignore-scripts here to avoid re-building again before pack run: | @@ -52,4 +53,4 @@ jobs: uses: actions/upload-artifact@v4 with: name: ${{ inputs.artifact_name || 'npm-package' }} - path: preact.tgz \ No newline at end of file + path: preact.tgz