Onetag Bid Adapter: remove unused fields sLeft and sTop (#14302)

* Remove unused properties sLeft and sTop from page info and response validation

* Update adapter version

---------

Co-authored-by: Diego Tomba <[email protected]>

Author: fliccione

modules/onetagBidAdapter.js

@@ -82,14 +82,14 @@ export function isValid(type, bid) {
   return false;
 }
 
-const isValidEventTracker = function(et) {
+const isValidEventTracker = function (et) {
   if (!et.event || !et.methods || !Number.isInteger(et.event) || !Array.isArray(et.methods) || !et.methods.length > 0) {
     return false;
   }
   return true;
 }
 
-const isValidAsset = function(asset) {
+const isValidAsset = function (asset) {
   if (!asset.hasOwnProperty("id") || !Number.isInteger(asset.id)) return false;
   const hasValidContent = asset.title || asset.img || asset.data || asset.video;
   if (!hasValidContent) return false;
@@ -210,7 +210,8 @@ function interpretResponse(serverResponse, bidderRequest) {
     const fledgeAuctionConfigs = body.fledgeAuctionConfigs
     return {
       bids,
-      paapi: fledgeAuctionConfigs}
+      paapi: fledgeAuctionConfigs
+    }
   } else {
     return bids;
   }
@@ -289,8 +290,6 @@ function getPageInfo(bidderRequest) {
     wHeight: winDimensions.innerHeight,
     sWidth: winDimensions.screen.width,
     sHeight: winDimensions.screen.height,
-    sLeft: null,
-    sTop: null,
     xOffset: topmostFrame.pageXOffset,
     yOffset: topmostFrame.pageYOffset,
     docHidden: getDocumentVisibility(topmostFrame),
@@ -299,7 +298,7 @@ function getPageInfo(bidderRequest) {
     timing: getTiming(),
     version: {
       prebid: '$prebid.version$',
-      adapter: '1.1.5'
+      adapter: '1.1.6'
     }
   };
 }
@@ -483,7 +482,7 @@ function getBidFloor(bidRequest, mediaType, sizes) {
 
     return {
       ...floorData,
-      size: size && size.length === 2 ? {width: size[0], height: size[1]} : null,
+      size: size && size.length === 2 ? { width: size[0], height: size[1] } : null,
       floor: floorData.floor != null ? floorData.floor : null
     };
   };

test/spec/modules/onetagBidAdapter_spec.js

@@ -491,7 +491,7 @@ describe('onetag', function () {
     });
     it('Should contain all keys', function () {
       expect(data).to.be.an('object');
-      expect(data).to.include.all.keys('location', 'referrer', 'stack', 'numIframes', 'sHeight', 'sWidth', 'docHeight', 'wHeight', 'wWidth', 'sLeft', 'sTop', 'hLength', 'bids', 'docHidden', 'xOffset', 'yOffset', 'networkConnectionType', 'networkEffectiveConnectionType', 'timing', 'version', 'fledgeEnabled');
+      expect(data).to.include.all.keys('location', 'referrer', 'stack', 'numIframes', 'sHeight', 'sWidth', 'docHeight', 'wHeight', 'wWidth', 'hLength', 'bids', 'docHidden', 'xOffset', 'yOffset', 'networkConnectionType', 'networkEffectiveConnectionType', 'timing', 'version', 'fledgeEnabled');
       expect(data.location).to.satisfy(function (value) {
         return value === null || typeof value === 'string';
       });
@@ -1131,8 +1131,6 @@ function getBannerVideoRequest() {
       wHeight: 949,
       sWidth: 1920,
       sHeight: 1080,
-      sLeft: null,
-      sTop: null,
       xOffset: 0,
       yOffset: 0,
       docHidden: false,