-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Description
In Prebid version 9.31.0 the ID5 module was updated which introduced an issue when using it in the combination with pubProvidedId.
In the case of the id5IdSystem and pubProvidedId providing a ID5 eid, every internal or external pbjs.getUserIdsAsEids() call is duplicating the ID5 eids from pubProvidedId, resulting in it duplicating itself on every auction.
During the troubleshooting, I tracked down the issue to the following:
- The ID5 module change introduces a function which returns an object reference: https://github.com/prebid/Prebid.js/pull/12745/files#diff-403b8e4d08d347eac6d6efa2d1171bcb64c0456cd6362006e8dd54f403d7122aR184
https://github.com/prebid/Prebid.js/releases/tag/9.31.0 - Prebid uses this reference as base object: https://github.com/prebid/Prebid.js/blob/9.53.x-legacy/modules/userId/eids.js#L63
- The eids from
pubProvidedIdare then added to it: https://github.com/prebid/Prebid.js/blob/9.53.x-legacy/modules/userId/eids.js#L61 - On the next iteration, the same object reference is used, already containing the eids from
pubProvidedId, while continuing to add them to it
It's possible other ID modules have the same issue.
The below test page shows the issue in the console, where pbjs.getUserIdsAsEids() returns the id helloworld123 several times.
Test page: https://jsfiddle.net/va6kf1ym/1/
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done