last few updates

Author: katherynhrabik

src/main/java/org/prebid/server/bidder/connatix/ConnatixBidder.java

@@ -49,6 +49,7 @@ public class ConnatixBidder implements Bidder<BidRequest> {
             };
 
     private static final String BIDDER_CURRENCY = "USD";
+    private static final String FORMATTING = "%s-%s";
 
     private final String endpointUrl;
     private final JacksonMapper mapper;
@@ -93,17 +94,16 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
     }
 
     private static String buildDisplayManagerVersion(BidRequest request) {
-        final String formatting = "%s-%s";
 
         return Optional.ofNullable(request.getApp())
                 .map(App::getExt)
                 .map(ExtApp::getPrebid)
                 .filter(prebid -> ObjectUtils.allNotNull(prebid.getSource(), prebid.getVersion()))
-                .map(prebid -> formatting.formatted(prebid.getSource(), prebid.getVersion()))
+                .map(prebid -> FORMATTING.formatted(prebid.getSource(), prebid.getVersion()))
                 .orElse(StringUtils.EMPTY);
     }
 
-    private MultiMap resolveHeaders(Device device) {
+    private static MultiMap resolveHeaders(Device device) {
         final MultiMap headers = HttpUtil.headers();
         if (device != null) {
             HttpUtil.addHeaderIfValueIsNotEmpty(headers, HttpUtil.USER_AGENT_HEADER, device.getUa());

src/test/java/org/prebid/server/bidder/connatix/ConnatixBidderTest.java

@@ -134,8 +134,7 @@ public void makeHttpRequestsShouldNotUpdateDisplayManagerVerIfPresent() {
                                 ExtAppPrebid.of("source", "version"), null))
                         .build()),
                 impBuilder -> impBuilder.displaymanagerver("displayManagerVer")
-                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity()))))
-        );
+                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity())))));
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -159,8 +158,7 @@ public void makeHttpRequestsShouldNotUpdateBannerIfFormatsIsEmpty() {
                                 .h(200)
                                 .format(Collections.emptyList())
                                 .build())
-                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity()))))
-        );
+                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity())))));
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -182,8 +180,7 @@ public void makeHttpRequestsShouldUpdateBanner() {
                 impBuilder -> impBuilder.banner(Banner.builder().format(List.of(
                         Format.builder().w(300).h(250).build(),
                                 Format.builder().w(1).h(1).build())).build())
-                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity()))))
-        );
+                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity())))));
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -200,8 +197,7 @@ public void makeHttpRequestsShouldUpdateBanner() {
                         .format(List.of(
                                 Format.builder().w(300).h(250).build(),
                                 Format.builder().w(1).h(1).build()))
-                        .build()
-                );
+                        .build());
     }
 
     @Test
@@ -214,8 +210,7 @@ public void makeHttpRequestsShouldConvertBidFloorWhenNotInBidderCurrency() {
                 impBuilder -> impBuilder
                         .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity()))))
                         .bidfloor(BigDecimal.ONE)
-                        .bidfloorcur("EUR")
-        );
+                        .bidfloorcur("EUR"));
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -243,8 +238,7 @@ public void makeHttpRequestsShouldSplitRequestIntoMultipleRequests() {
                                 .placementId("placement1").build()))),
                 impBuilder -> impBuilder
                         .ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpConnatix.builder()
-                                .placementId("placement2").build())))
-        );
+                                .placementId("placement2").build()))));
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -260,8 +254,7 @@ public void makeHttpRequestsShouldIncludeResolvedHttpHeadersFromDevice() {
         final BidRequest bidRequest = givenBidRequest(
                 request -> request.device(Device.builder().ip("deviceIp").ipv6("deviceIpv6").ua("userAgent").build()),
                 impBuilder -> impBuilder
-                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity()))))
-        );
+                        .ext(mapper.valueToTree(ExtPrebid.of(null, givenExt(UnaryOperator.identity())))));
 
         // when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -277,8 +270,7 @@ public void makeHttpRequestsShouldIncludeResolvedHttpHeadersFromDevice() {
                         tuple(HttpUtil.X_FORWARDED_FOR_HEADER.toString(), "deviceIp"),
                         tuple(HttpUtil.X_FORWARDED_FOR_HEADER.toString(), "deviceIpv6"),
                         tuple(HttpUtil.CONTENT_TYPE_HEADER.toString(), HttpUtil.APPLICATION_JSON_CONTENT_TYPE),
-                        tuple(HttpUtil.ACCEPT_HEADER.toString(), HttpHeaderValues.APPLICATION_JSON.toString())
-                );
+                        tuple(HttpUtil.ACCEPT_HEADER.toString(), HttpHeaderValues.APPLICATION_JSON.toString()));
     }
 
     @Test