Skip to content

Commit 27b9b19

Browse files
Alkimi: Added support for Imp extention object (#3743)
1 parent 299b770 commit 27b9b19

File tree

4 files changed

+17
-8
lines changed

4 files changed

+17
-8
lines changed

src/main/java/org/prebid/server/bidder/alkimi/AlkimiBidder.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,16 @@ private ExtImpAlkimi parseImpExt(Imp imp) {
6767
private Imp updateImp(Imp imp, ExtImpAlkimi extImpAlkimi) {
6868
final Price bidFloorPrice = Price.of(imp.getBidfloorcur(), imp.getBidfloor());
6969

70+
final ObjectNode newExt = imp.getExt().deepCopy();
71+
newExt.replace("bidder", makeImpExt(imp, extImpAlkimi));
72+
7073
return imp.toBuilder()
7174
.bidfloor(BidderUtil.isValidPrice(bidFloorPrice)
7275
? bidFloorPrice.getValue()
7376
: extImpAlkimi.getBidFloor())
7477
.instl(extImpAlkimi.getInstl())
7578
.exp(extImpAlkimi.getExp())
76-
.ext(makeImpExt(imp, extImpAlkimi))
79+
.ext(newExt)
7780
.build();
7881
}
7982

@@ -82,7 +85,7 @@ private ObjectNode makeImpExt(Imp imp, ExtImpAlkimi extImpAlkimi) {
8285

8386
extBuilder.adUnitCode(imp.getId());
8487

85-
return mapper.mapper().valueToTree(ExtPrebid.of(null, extBuilder.build()));
88+
return mapper.mapper().valueToTree(extBuilder.build());
8689
}
8790

8891
@Override

src/test/java/org/prebid/server/bidder/alkimi/AlkimiBidderTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import java.math.BigDecimal;
2626
import java.util.Collections;
2727
import java.util.List;
28+
import java.util.Map;
2829
import java.util.function.Function;
2930

3031
import static java.util.Collections.singletonList;
@@ -109,9 +110,10 @@ private Banner expectedBanner() {
109110
}
110111

111112
private ObjectNode expectedBannerExt() {
112-
return mapper.valueToTree(ExtPrebid.of(
113-
null,
114-
ExtImpAlkimi.builder()
113+
return mapper.valueToTree(Map.of(
114+
"tid", "12345",
115+
"gpid", "300x250",
116+
"bidder", ExtImpAlkimi.builder()
115117
.token(PUB_TOKEN)
116118
.bidFloor(BigDecimal.valueOf(0.2))
117119
.instl(1)
@@ -252,9 +254,10 @@ private static Imp givenBannerImp(Function<Imp.ImpBuilder, Imp.ImpBuilder> impCu
252254
.h(250)
253255
.build())
254256
).build())
255-
.ext(mapper.valueToTree(ExtPrebid.of(
256-
null,
257-
ExtImpAlkimi.builder()
257+
.ext(mapper.valueToTree(Map.of(
258+
"tid", "12345",
259+
"gpid", "300x250",
260+
"bidder", ExtImpAlkimi.builder()
258261
.token(PUB_TOKEN)
259262
.bidFloor(BigDecimal.valueOf(0.2))
260263
.instl(1)

src/test/resources/org/prebid/server/it/openrtb2/alkimi/test-alkimi-bid-request.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
},
1414
"bidfloor": 0.5,
1515
"ext": {
16+
"tid": "${json-unit.any-string}",
17+
"gpid": "640x480",
1618
"bidder": {
1719
"token": "XXX",
1820
"bidFloor": 0.5,

src/test/resources/org/prebid/server/it/openrtb2/alkimi/test-auction-alkimi-request.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"h": 480
1212
},
1313
"ext": {
14+
"gpid": "640x480",
1415
"alkimi": {
1516
"bidFloor": 0.5,
1617
"token": "XXX"

0 commit comments

Comments
 (0)