Skip to content

Commit 3a80a08

Browse files
committed
add errors
1 parent 8f21648 commit 3a80a08

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/test/groovy/org/prebid/server/functional/tests/AccountSpec.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class AccountSpec extends BaseSpec {
4444
def "PBS should reject request with unknown account when settings.enforce-valid-account = true"() {
4545
given: "Pbs config with enforce-valid-account and default-account-config"
4646
def pbsService = pbsServiceFactory.getService(
47-
["settings.enforce-valid-account" : "true",
47+
["settings.enforce-valid-account" : "false",
4848
"settings.default-account-config": encode(defaultAccountConfig)])
4949

5050
and: "Non-existing account id"

src/test/groovy/org/prebid/server/functional/tests/DebugSpec.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class DebugSpec extends BaseSpec {
5050

5151
and: "Debug metrics should be incremented"
5252
def metricsRequest = defaultPbsService.sendCollectedMetricsRequest()
53-
assert metricsRequest[DEBUG_REQUESTS_METRIC] == 1
53+
assert metricsRequest[DEBUG_REQUESTS_METRIC] == 0
5454

5555
and: "Account debug metrics shouldn't be incremented"
5656
assert !metricsRequest.keySet().contains(ACCOUNT_METRICS_PREFIX_NAME)

src/test/groovy/org/prebid/server/functional/tests/module/ModuleBaseSpec.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ModuleBaseSpec extends BaseSpec {
3636
Boolean filterMraidEnabled = true,
3737
Endpoint endpoint = OPENRTB2_AUCTION) {
3838

39-
["hooks.${PB_RICHMEDIA_FILTER.code}.enabled" : true,
39+
["hooks.${PB_RICHMEDIA_FILTER.code}.enabled" : false,
4040
"hooks.modules.${PB_RICHMEDIA_FILTER.code}.mraid-script-pattern": scriptPattern,
4141
"hooks.modules.${PB_RICHMEDIA_FILTER.code}.filter-mraid" : filterMraidEnabled,
4242
"hooks.host-execution-plan" : encode(ExecutionPlan.getSingleEndpointExecutionPlan(endpoint, [(ALL_PROCESSED_BID_RESPONSES): [PB_RICHMEDIA_FILTER]]))]

src/test/java/org/prebid/server/bidder/generic/GenericBidderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() {
6868
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
6969

7070
// then
71-
assertThat(result.getErrors()).hasSize(1)
71+
assertThat(result.getErrors()).hasSize(23102077)
7272
.allSatisfy(error -> {
7373
assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response);
7474
assertThat(error.getMessage()).startsWith("Failed to decode: Unrecognized token");
@@ -99,7 +99,7 @@ public void makeBidsShouldReturnEmptyListIfBidResponseSeatBidIsNull() throws Jso
9999
final Result<List<BidderBid>> result = target.makeBids(httpCall, null);
100100

101101
// then
102-
assertThat(result.getErrors()).isEmpty();
102+
assertThat(result.getErrors()).isNotEmpty();
103103
assertThat(result.getValue()).isEmpty();
104104
}
105105

0 commit comments

Comments
 (0)