fix review: Locale nullable

EvgeniiMunin · EvgeniiMunin · commit 40113b401ade · 2025-01-07T16:45:19.000+01:00
diff --git a/extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInferenceDataService.java b/extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInferenceDataService.java
@@ -113,11 +113,9 @@ private List<ThrottlingMessage> extractMessagesForImp(
     }
 
     private static String getCountryNameFromAlpha2(String isoCode) {
-        return Optional.ofNullable(isoCode)
-                .filter(code -> !code.isBlank())
-                .map(code -> new Locale(StringUtils.EMPTY, code))
-                .map(Locale::getDisplayCountry)
-                .orElse(StringUtils.EMPTY);
+        return StringUtils.isBlank(isoCode)
+                ? StringUtils.EMPTY
+                : new Locale(StringUtils.EMPTY, isoCode).getDisplayCountry();
     }
 
     private String getCountry(String ip) {

Original file line number	Diff line number	Diff line change
`@@ -113,11 +113,9 @@ private List<ThrottlingMessage> extractMessagesForImp(`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`private static String getCountryNameFromAlpha2(String isoCode) {`
`116`		`- return Optional.ofNullable(isoCode)`
`117`		`- .filter(code -> !code.isBlank())`
`118`		`- .map(code -> new Locale(StringUtils.EMPTY, code))`
`119`		`- .map(Locale::getDisplayCountry)`
`120`		`- .orElse(StringUtils.EMPTY);`
	`116`	`+ return StringUtils.isBlank(isoCode)`
	`117`	`+ ? StringUtils.EMPTY`
	`118`	`+ : new Locale(StringUtils.EMPTY, isoCode).getDisplayCountry();`
`121`	`119`	`}`
`122`	`120`
`123`	`121`	`private String getCountry(String ip) {`